minor changes to make it work on my machine - #5
Conversation
| const page = await browser.newPage(); | ||
| await page.setViewport({ width: 1920, height: 1080 }); | ||
| await page.goto(url, { waitUntil: "domcontentloaded" }); | ||
| page.on('console', msg => console.log(msg.text())); |
There was a problem hiding this comment.
only needed for efficient debug on my part
| await new Promise((r) => setTimeout(r, 500)); // wait ig? | ||
|
|
||
| await page.waitForSelector('#accept-btn') | ||
| await page.click('#accept-btn'); |
There was a problem hiding this comment.
Those two lines needed in order to pass the "accept cookies" stage
| let otherPages: string[] = []; | ||
| for (let i = 0; i < totalPages - 1; i++) { | ||
| await page.mouse.wheel({ deltaY: 1185 }); | ||
| for (let i = 0; i < totalPages*2; i++) { |
There was a problem hiding this comment.
didn't quite understand the scrolling logic. With this settings it should be able to handle very long and very short scores equally well without skipping any pages
| const browser = await puppeteer.launch(); | ||
| const browser = await puppeteer.launch({ | ||
| args: [ | ||
| '--no-sandbox', '--disable-setuid-sandbox'] |
There was a problem hiding this comment.
needed to make it work on my machine
|
Hey there, thanks for contributing! I think that the cookie pop-up might be a regional thing, since I don't get any sort of pop-up here in the United States, but switching on my VPN to France, I was able to see the pop-up you're talking about (at least when using Safari, I think Firefox blocks this by default). I still think something weird might be going on because I wasn't able to replicate the issue you're having with scroll behavior not working, even through the VPN to France. Unfortunately, the added Despite this, I'm glad you were able to find the tool helpful and were able to get it working for you! |
I needed to add the code in order to make the app function properly :
Was able to download https://musescore.com/user/59704117/scores/17288323 on my machine.
Hope it helps !