This repository was archived by the owner on Aug 23, 2022. It is now read-only.
Fix for truffle 5 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @motonauta. Thank you for contributing. Is this related to #1? |
|
This looks like it is related to my issue. I think the solution may have a problem when the contract you are converting from has events emitted. Couldn't the short circuit find a false positive for the given index? |
Author
|
Hi guys! yes, is my solution to #1 |
|
@zulhfreelancer I ended up here and with the proposed fix it is working properly now. When the merge ? |
|
Hi @zulhfreelancer, I recently came across this project, and found it works quite nicely. I also confirmed this patch is needed for Truffle 5. Will you be able to merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.