gitlint: Setup commit linter. #367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyank-p
force-pushed
the
commit-linter
branch
from
dd7ce81 to
f1f586d
Compare
akashnimare
requested changes
Jan 5, 2018
| @@ -0,0 +1,73 @@ | |||
| // This script sets up the pre-push | |||
| // git hook which we will be used to lint | |||
akashnimare
requested changes
Jan 5, 2018
package.json
Outdated
| @@ -27,6 +27,9 @@ | |||
| "pack": "electron-builder --dir", | |||
| "dist": "electron-builder", | |||
| "mas": "electron-builder --mac mas", | |||
| "setup-gitlint-hooks": "node ./scripts/gitlint/setup-gitlint-hook", | |||
| "lint-commits": "node ./scripts/gitlint --all-commits", | |||
| "lint-fix": "xo --fix", | |||
There was a problem hiding this comment.
Can you remove lint-fix because xo --fix doesn't work all the time and may give you unexpected results.
priyank-p
force-pushed
the
commit-linter
branch
from
f1f586d to
6cb367b
Compare
priyank-p
force-pushed
the
commit-linter
branch
2 times, most recently
from
a7ec3f9 to
b8b877d
Compare
akashnimare
approved these changes
Jan 29, 2018
priyank-p
force-pushed
the
commit-linter
branch
from
0047763 to
720f42c
Compare
priyank-p
force-pushed
the
commit-linter
branch
from
36a91b4 to
72eb5c2
Compare
This will setup a commit hook that will check the commit msg run `npm run lint-commits` to check all the commits. Additionaly setup git hooks by running `npm run setup-gitlint-hooks`.
priyank-p
force-pushed
the
commit-linter
branch
from
35384af to
8fa1a60
Compare
akashnimare
force-pushed
the
master
branch
2 times, most recently
from
abd41fb to
94cbc78
Compare
|
Heads up @priyank-p, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
This thing is almost three years old :). Closing this I don't think we want this now. |
|
@kanishk98 and I were thinking to revisit this. We definitely want to add this tool. |
|
OK, restored I don't remember anything at this point so closed it, reopening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will setup a commit hook that will check the commit msg run
npm run lint-commitsto check all the commits.What's this PR do?
Setup commit linter.
Screenshots?
You have tested this PR on: