-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate database to LevelDB. #810
base: main
Are you sure you want to change the base?
Conversation
Ah, silly mistake on my part - I was moving around |
dab6948
to
a9d19f9
Compare
I think this PR's ready for review now. @priyank-p and @akashnimare please have a look at this whenever you find time. :) |
Heads up @kanishk98, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
@akashnimare Are there only merge conflicts or there's something else as @kanishk98 says it's ready for review. |
Hey @manavmehta, great to see some new faces around here! |
I think this was a fairly involved PR, so if LevelDB still solves our database-level problems, it would be easier and quicker if I were to just update my PR according to master. I'm just trying to be cognizant of GSoC processes at the same time. |
@kanishk98 awesome. In case you and @akashnimare feel I should build upon this, I would surely appreciate your help! |
What's this PR do?
Changes database module used for maintaining
settings.json
toleveldb
. Uses a node wrapper around it.Any background context you want to provide?
We need to move database operations to one process to avoid app crashes (which used to happen earlier). LevelDB also uses locking and can therefore handle corner cases better than
node-json-db
.You have tested this PR on: