New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak dark theme #1213

Merged

gnprice merged 5 commits into zulip:main from Gaurav-Kushwaha-1225:TweakDarkTheme

Mar 3, 2025

Contributor

Gaurav-Kushwaha-1225 commented Dec 27, 2024 •

edited

Loading

About Changes

This PR updates the color variables in DesignVariables and MessageListTheme for a slightly higher contrast in dark theme according to the values in the figma file.

Fixes: #973

Screenshots

Before	After

Collaborator

alya commented Dec 27, 2024

Please clean up your commit history and post again to request a review. See here for guidelines.

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from 525b063 to 3af0d2e Compare

December 27, 2024 18:25

Contributor Author

Gaurav-Kushwaha-1225 commented Dec 27, 2024

Please clean up your commit history and post again to request a review. See here for guidelines.

I’ve cleaned up the commit history by removing unnecessary merge commits into the TweakDarkTheme branch and combining related changes into a single commit for clarity.

This is my first time using rebase -i. During the process, I used pick, squash, and drop commands for various commits. I initially thought there would be separate commit messages for each, but later realized they were combined into one during the rebase.
Although, it asked to enter three commit messages after rebasing, Idk why it happened. Could you please explain why all commit messages were merged into one?
I’d like to understand this better for future contributions.

Apologies for any confusion.

Please review the updated PR.

Member

gnprice commented Dec 27, 2024

The #git help channel on chat.zulip.org is a good place to ask questions about using Git.

Contributor Author

Gaurav-Kushwaha-1225 commented Jan 5, 2025

Please clean up your commit history and post again to request a review. See here for guidelines.

Hi @alya, please review the updated PR.

Collaborator

alya commented Jan 6, 2025

Thanks! I'll let other folks take a look at this one.

gnprice added the maintainer review label

gnprice assigned PIG208

Member

PIG208 commented Jan 8, 2025 •

edited

Loading

Hi! Please read through the commit style guide (also previously linked by Alya) linked in our README and fix the commit message: https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from 076d0de to 139d4e5 Compare

January 8, 2025 22:17

PIG208 reviewed

View reviewed changes

Member

PIG208 left a comment

Thanks for the PR! I noted the differences between this revision and the Figma design after going through lib/widgets/message_list.dart and some part of lib/widgets/compose_box.dart for colors used in the widgets.

Some of the comments are just about different colors being used, and others request the addition/removal of variables. It should be fine to include color adjustments all in a single commit, but for adding/removing variables, let's try to have separate commits for the ones added, so it is easier to see which variables they replace. Consider using the NFC tag if a commit is a pure refactor.

I think there are also changes to the autocomplete window, but that should be addressed in #995,

lib/widgets/message_list.dart Outdated Show resolved Hide resolved

lib/widgets/theme.dart Outdated Show resolved Hide resolved

lib/widgets/message_list.dart Outdated Show resolved Hide resolved

lib/widgets/message_list.dart Outdated Show resolved Hide resolved

lib/widgets/theme.dart Outdated Show resolved Hide resolved

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Adjust foreground & dateSeparator colors

549fd70

Adjusted the colors for `foreground` in
`DesignVariables` and `dateSeparator` in `MessageListTheme`
as asked.
`foreground`: zulip#1213 (comment)
`dateSeparator`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Added labelTime variable in MessageListTheme

9c71065

Added `labelTime` variable in `MessageListTheme`
that replaces the `dateSeparatorText` and
`messageTimestamp` variable according to the latest
design.

`labelTime`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from 9c71065 to 139d4e5 Compare

January 12, 2025 23:46

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Adjust foreground & dateSeparator colors

47b011b

Adjusted the colors for `foreground` in
`DesignVariables` and `dateSeparator` in
`MessageListTheme` as asked.

`foreground`: zulip#1213 (comment)
`dateSeparator`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Added labelTime variable in MessageListTheme

69471f0

Added `labelTime` variable in `MessageListTheme`
that replaces the `dateSeparatorText` and
`messageTimestamp` variable according to the latest
design.

`labelTime`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Adjust foreground & dateSeparator colors

3f7720b

Adjusted the colors for `foreground` in
`DesignVariables` and `dateSeparator` in
`MessageListTheme` as asked.

`foreground`: zulip#1213 (comment)
`dateSeparator`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Added labelTime variable in MessageListTheme

4572fe7

Added `labelTime` variable in `MessageListTheme`
that replaces the `dateSeparatorText` and
`messageTimestamp` variable according to the latest
design.

`labelTime`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from 56f8fdb to 2a11a43 Compare

January 15, 2025 01:29

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Added labelTime variable in MessageListTheme

ce64ca5

Added `labelTime` variable in `MessageListTheme`
that replaces the `dateSeparatorText` and
`messageTimestamp` variable according to the latest
design.

`labelTime`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from 2a11a43 to ce64ca5 Compare

January 15, 2025 01:41

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Adjust foreground & dateSeparator colors

f9afb86

Adjusted the colors for `foreground` in
`DesignVariables` and `dateSeparator` in `MessageListTheme`
as asked.
`foreground`: zulip#1213 (comment)
`dateSeparator`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Added labelTime variable in MessageListTheme

c6aca86

Added `labelTime` variable in `MessageListTheme`
that replaces the `dateSeparatorText` and
`messageTimestamp` variable according to the latest
design.

`labelTime`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from ce64ca5 to c6aca86 Compare

January 15, 2025 02:03

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme[nfc]: Remove colorMessageHeaderIconInteractive

4b70f9f

Removed `colorMessageHeaderIconInteractive` from
`DesignVariables` and used `title` in place of it
as per the design guidelines.
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme[nfc]: Remove senderName & recipientHeaderText

2f4089e

Removed `senderName` & `recipientHeaderText` from
`MessageListTheme` and used `title` in place of it
as per the design guidelines.
discussion: zulip#1213 (comment)

chrisbobbe mentioned this pull request

Display user facing version information in menu #1095

Open

0pni approved these changes

View reviewed changes

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Adjust foreground & dateSeparator colors

fc75907

Adjusted the colors for `foreground` in
`DesignVariables` and `dateSeparator` in `MessageListTheme`
as asked.
`foreground`: zulip#1213 (comment)
`dateSeparator`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Added labelTime variable in MessageListTheme

28fbba2

Added `labelTime` variable in `MessageListTheme`
that replaces the `dateSeparatorText` and
`messageTimestamp` variable according to the latest
design.

`labelTime`: zulip#1213 (comment)

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from aee7e68 to fb30dd0 Compare

February 22, 2025 11:38

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace senderName & recipientHeaderText with title

4cc0e76

The `senderName` & `recipientHeaderText` giving colors to name of sender
in each message and left icon + text in the Message Header of both Stream
messages and DMs, respectively, have been replaced to a lighter and darker
versions in dark and light themes, respectively, using the `title`
variable of `DesignVariables`, according to the Figma Design.

Note: left icon in the Message Header of Stream message is added just to
give hspace (see line no. 1075 in `lib/widgets/message_list.dart`).

This specific UI of left icon and text in message header for the DMs
doesn't appear in the Figma design, but we use `title` variable because
`recipientHeaderText` was used previously for coloring them.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace streamMessageBgDefault with bgMessageRegular

91df707

The `streamMessageBgDefault` giving colors to the background of both
Stream messages and DMs UI, has been changed to a darker version for the
dark theme, using a new `bgMessageRegular` variable in the
`MessageListTheme`, according to the Figma design. It's just a refactor
of variable for the light theme.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace dateSeparator with foreground

91bd479

The variable giving color to divider lines in the Message List UI
i.e. `dateSeparator` has been replaced with the `foreground` variable
of `DesignVariables`, according to the Figma design.
There isn't any change in the values of color from the previous one i.e.
`dateSeparator`.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Fixes: zulip#973

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from fb30dd0 to 91bd479 Compare

February 22, 2025 12:52

Contributor Author

Gaurav-Kushwaha-1225 commented Feb 22, 2025

Hi @gnprice,
I have updated the commit messages as required and below are the commits with a short description and screenshots for you to review.

Commit 1: 266833e

Before	After

Commit 2: 65b5bdb
- This commit reduces the opacity, causing the time and date stamp to appear lighter/less opaque in both themes. Should I explicitly mention this in the commit message, or would a different phrasing be more appropriate to avoid confusion with "lighter" in other commits?

Before	After

Commit 3: 4cc0e76

Before	After

Commit 4: 91df707

Before	After

Commit 5: 91bd479

Before	After

gnprice reviewed

View reviewed changes

Member

gnprice left a comment

Thanks @Gaurav-Kushwaha-1225 for the revision — this is quite a lot better. A few specific comments below.

lib/widgets/message_list.dart Show resolved Hide resolved

lib/widgets/message_list.dart Show resolved Hide resolved

lib/widgets/message_list.dart Show resolved Hide resolved

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace dateSeparatorText & messageTimestamp with labelTime

The `dateSeparatorText` and `messageTimestamp`, which define the color
of the date and time stamps on messages and message headers, have been
replaced with a lower-contrast version in both dark and light themes.
This is done using a new `labelTime` variable in `MessageListTheme`,
aligning with the Figma Design.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=QCuXEn8bYVbf4Fli-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace senderName & recipientHeaderText with title

c122ec2

The `senderName` & `recipientHeaderText` giving colors to name of sender
in each message and left icon + text in the Message Header of both Stream
messages and DMs, respectively, have been replaced to a lighter and darker
versions in dark and light themes, respectively, using the `title`
variable of `DesignVariables`, according to the Figma Design.

This specific UI of left icon and text in message header for the DMs
doesnt appear in the Figma design, but we use `title` variable because
`recipientHeaderText` was used previously for coloring them.

Figma:
- https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
- https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4010-6352&t=9j2mOkL1Pds0XVAE-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace streamMessageBgDefault with bgMessageRegular

e0a4dd5

The `streamMessageBgDefault` giving colors to the background of both
Stream messages and DMs UI, has been changed to a darker version for the
dark theme, using a new `bgMessageRegular` variable in the
`MessageListTheme`, according to the Figma design. It's just a refactor
of variable for the light theme.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme [nfc]: Replace dateSeparator with foreground

de781cd

The variable giving color to divider lines in the Message List UI
i.e. `dateSeparator` has been replaced with the `foreground` variable
of `DesignVariables`, according to the Figma design.
There isn't any change in the values of color from the previous one i.e.
`dateSeparator`.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Fixes: zulip#973

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from 91bd479 to de781cd Compare

February 27, 2025 15:14

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace colorMessageHeaderIconInteractive with title

14ec020

The `colorMessageHeaderIconInteractive` giving color to follow/mute
icons beside topic names have been replaced to a lighter and darker
versions in dark and light themes respectively, using the `title`
variable of `DesignVariables`.

This specific UI doesn't appear in the Figma design, but we use `title`
because it's used there for the color of a dropdown icon that also
appears next to topics.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4021-7569&t=b56sVJ6in9zEY1tU-0
discussion: zulip#1213 (comment), zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace dateSeparatorText & messageTimestamp with labelTime

b40c51d

The `dateSeparatorText` and `messageTimestamp`, which define the color
of the date and time stamps on messages and message headers, have been
replaced with a lower-contrast version in both dark and light themes.
This is done using a new `labelTime` variable in `MessageListTheme`,
aligning with the Figma Design.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=QCuXEn8bYVbf4Fli-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace senderName & recipientHeaderText with title

6bb8680

The `senderName` & `recipientHeaderText` giving colors to name of sender
in each message and left icon + text in the Message Header of both Stream
messages and DMs, respectively, have been replaced to a lighter and darker
versions in dark and light themes, respectively, using the `title`
variable of `DesignVariables`, according to the Figma Design.

This specific UI of left icon and text in message header for the DMs
doesnt appear in the Figma design, but we use `title` variable because
`recipientHeaderText` was used previously for coloring them.

Figma:
- https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
- https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4010-6352&t=9j2mOkL1Pds0XVAE-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace streamMessageBgDefault with bgMessageRegular

4a4c9ff

The `streamMessageBgDefault` giving colors to the background of both
Stream messages and DMs UI, has been changed to a darker version for the
dark theme, using a new `bgMessageRegular` variable in the
`MessageListTheme`, according to the Figma design. It's just a refactor
of variable for the light theme.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme [nfc]: Replace dateSeparator with foreground

baef2c7

The variable giving color to divider lines in the Message List UI
i.e. `dateSeparator` has been replaced with the `foreground` variable
of `DesignVariables`, according to the Figma design.
There isn't any change in the values of color from the previous one i.e.
`dateSeparator`.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Fixes: zulip#973

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from de781cd to baef2c7 Compare

February 27, 2025 15:36

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme: Replace streamMessageBgDefault with bgMessageRegular

11ab341

The `streamMessageBgDefault` giving colors to the background of both
Stream messages and DMs UI, has been changed to a darker version for the
dark theme, using a new `bgMessageRegular` variable in the
`MessageListTheme`, according to the Figma design. It's just a refactor
of variable for the light theme.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Gaurav-Kushwaha-1225 added a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this pull request


          theme [nfc]: Replace dateSeparator with foreground

9ae39ae

The variable giving color to divider lines in the Message List UI
i.e. `dateSeparator` has been replaced with the `foreground` variable
of `DesignVariables`, according to the Figma design.
There isn't any change in the values of color from the previous one i.e.
`dateSeparator`.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Fixes: zulip#973

Gaurav-Kushwaha-1225 force-pushed the TweakDarkTheme branch from baef2c7 to 9ae39ae Compare

February 27, 2025 15:39

Gaurav-Kushwaha-1225 requested a review from gnprice

February 27, 2025 17:07

Gaurav-Kushwaha-1225 added 5 commits

March 3, 2025 13:57


          theme: Replace colorMessageHeaderIconInteractive with title

7ee4431

The `colorMessageHeaderIconInteractive` giving color to follow/mute
icons beside topic names have been replaced to a lighter and darker
versions in dark and light themes respectively, using the `title`
variable of `DesignVariables`.

This specific UI doesn't appear in the Figma design, but we use `title`
because it's used there for the color of a dropdown icon that also
appears next to topics.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4021-7569&t=b56sVJ6in9zEY1tU-0
discussion: zulip#1213 (comment), zulip#1213 (comment)


          theme: Replace dateSeparatorText & messageTimestamp with labelTime

18b8725

The `dateSeparatorText` and `messageTimestamp`, which define the color
of the date and time stamps on messages and message headers, have been
replaced with a lower-contrast version in both dark and light themes.
This is done using a new `labelTime` variable in `MessageListTheme`,
aligning with the Figma Design.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=QCuXEn8bYVbf4Fli-0
discussion: zulip#1213 (comment)


          theme: Replace senderName & recipientHeaderText with title

a6c6af4

The `senderName` & `recipientHeaderText` giving colors to name of sender
in each message and left icon + text in the Message Header of both Stream
messages and DMs, respectively, have been replaced to a lighter and darker
versions in dark and light themes, respectively, using the `title`
variable of `DesignVariables`, according to the Figma Design.

This specific UI of left icon and text in message header for the DMs
doesnt appear in the Figma design, but we use `title` variable because
`recipientHeaderText` was used previously for coloring them.

Figma:
- https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
- https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4010-6352&t=9j2mOkL1Pds0XVAE-0
discussion: zulip#1213 (comment)


          theme: Replace streamMessageBgDefault with bgMessageRegular

59f13a9

The `streamMessageBgDefault` giving colors to the background of both
Stream messages and DMs UI, has been changed to a darker version for the
dark theme, using a new `bgMessageRegular` variable in the
`MessageListTheme`, according to the Figma design. It's just a refactor
of variable for the light theme.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)


          theme [nfc]: Replace dateSeparator with foreground

46a8cdb

The variable giving color to divider lines in the Message List UI
i.e. `dateSeparator` has been replaced with the `foreground` variable
of `DesignVariables`, according to the Figma design.
There isn't any change in the values of color from the previous one i.e.
`dateSeparator`.

Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4993-20811&t=vu2wWOBiVb0BB6Vz-0
discussion: zulip#1213 (comment)

Fixes: zulip#973

Member

gnprice commented Mar 3, 2025

Thanks for the revision! Looks good now; merging.

gnprice force-pushed the TweakDarkTheme branch from 9ae39ae to 46a8cdb Compare

March 3, 2025 21:59

gnprice merged commit 46a8cdb into zulip:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration review