Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msglist: Move star icon 2px away from the edge of the screen #1249

Merged
merged 1 commit into from
Feb 14, 2025
Merged

msglist: Move star icon 2px away from the edge of the screen #1249

merged 1 commit into from
Feb 14, 2025

Conversation

lakshya1goel
Copy link
Contributor

Fixes: #1247

Before After
WhatsApp Image 2025-01-03 at 9 21 11 AM WhatsApp Image 2025-01-03 at 9 21 11 AM(1)

chrisbobbe
chrisbobbe requested changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Comments below.

@gnprice gnprice added the maintainer review PR ready for review by Zulip maintainers label Jan 17, 2025
chrisbobbe
chrisbobbe reviewed Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Glad to have this simpler, clearer implementation. 🙂 Small comments below.

@lakshya1goel
Copy link
Contributor Author

Thanks for the review @chrisbobbe, pushed the required changes, PTAL.

@lakshya1goel
Copy link
Contributor Author

lakshya1goel commented Feb 5, 2025 •
edited
Loading

Hi @chrisbobbe , mentioning you for follow up, PTAL when you get some time. Thanks!

chrisbobbe
chrisbobbe reviewed Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small comments below.

@lakshya1goel
Copy link
Contributor Author

Thanks for the review, I have pushed the revision. PTAL.

@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Marking for Greg's review.

@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Feb 11, 2025
@chrisbobbe chrisbobbe requested a review from gnprice February 11, 2025 19:35
gnprice
gnprice reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to you both! The logic here looks good. A couple of comments below.

@lakshya1goel lakshya1goel requested a review from gnprice February 13, 2025 10:33
@lakshya1goel
Copy link
Contributor Author

Thanks for the review @gnprice, pushed the revision, PTAL!

gnprice
gnprice reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of small comments still.

@lakshya1goel lakshya1goel requested a review from gnprice February 14, 2025 14:32
@lakshya1goel
Copy link
Contributor Author

Pushed the revision, PTAL. Thanks!

@gnprice
Copy link
Member

gnprice commented Feb 14, 2025

Thanks! Looks good; merging.

@gnprice gnprice merged commit 44df81f into zulip:main Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbobbe chrisbobbe Awaiting requested review from chrisbobbe

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

@chrisbobbe chrisbobbe

Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msglist: Move star icon 2px away from the edge of the screen
3 participants
@lakshya1goel @chrisbobbe @gnprice