notif ios: Handle opening of conversation on tap; take 2 #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
force-pushed
the
dev-ios-notif-2
branch
5 times, most recently
from
463b9ee to
8478226
Compare
rajveermalviya
force-pushed
the
dev-ios-notif-2
branch
2 times, most recently
from
0142dbd to
89df63b
Compare
rajveermalviya
force-pushed
the
dev-ios-notif-2
branch
from
89df63b to
4f3224a
Compare
rajveermalviya
added
the
maintainer review
rajveermalviya
force-pushed
the
dev-ios-notif-2
branch
2 times, most recently
from
80a34eb to
9c07740
Compare
|
Ah this has gathered a conflict in lib/widgets/app.dart; could you resolve it please? (I see you did a few days ago, but looks like it's happened again; thanks. 🙂) |
rajveermalviya
force-pushed
the
dev-ios-notif-2
branch
2 times, most recently
from
807d865 to
3b50218
Compare
Moves the actual loading of GlobalStore from GlobalStoreWidget to _ZulipAppState.intiState. This will allow to do some other tasks concurrently while the GlobalStore is loading and showing the placeholder while they complete.
Introduces a new Pigeon API file, and adds the corresponding bindings in Swift. Unlike the `pigeon/android_notifications.dart` API this doesn't use the ZulipPlugin hack, as that is only needed when we want the Pigeon functions to be available inside a background isolate (see doc in `zulip_plugin/pubspec.yaml`). Since the notification tap will trigger an app launch first (if not running already) anyway, we can be sure that these new functions won't be running on a Dart background isolate, thus not needing the ZulipPlugin hack.
rajveermalviya
force-pushed
the
dev-ios-notif-2
branch
from
3b50218 to
2178fe6
Compare
|
(Rebased to main, Thanks!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1147.
2nd attempt, first attempt was #1261. This one uses pigeon to move most of the notification payload handling to dart side (and doesn't use/rely on
zulip://notificationURL).