Add empty-state illustrations - #2354
Conversation
efe7536 to
c5adf02
Compare
|
CI is showing a change in ios/Podfile.lock after running pod install, causing tools/check ios to fail due to a modified lockfile. I’m on Windows and don’t have macOS available to run CocoaPods locally. Should I commit the CI-updated Podfile.lock, or is the current version expected to remain unchanged? |
a4f4e74 to
99e9ba3
Compare
|
Thanks for the PR!
|
0406e2e to
1343b82
Compare
|
Done, I've switched the new illustrations to vector_graphics and updated the assets accordingly. |
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Thanks for the revision. Here are some comments from a very brief skim. Please also clean up code style to match surrounding style: indentation, newlines, etc.
| vector_graphics: 1.2.2 | ||
| # Keep list sorted when adding dependencies; it helps prevent merge conflicts. |
There was a problem hiding this comment.
Please follow the comment here.
| leading: Center( | ||
| child: ClipRRect( | ||
| borderRadius: BorderRadius.circular(8), | ||
| child: const VectorGraphic( | ||
| loader: AssetBytesLoader( | ||
| 'assets/app-icons/zulip-combined.svg.vec', | ||
| ), | ||
| width: 40, | ||
| height: 40, | ||
| ), | ||
| ), | ||
| ), | ||
| centerTitle: true, |
| @@ -0,0 +1,41 @@ | |||
| name: Fix iOS Build Files | |||
There was a problem hiding this comment.
This file should not be needed.
1343b82 to
57b798d
Compare
|
Thanks! I've addressed the review comments, Please take another look when you have a chance. |
|
Thanks for the revision. From another very brief look, I see the PR title and description still refer to "org icon" and #1606; please update that. It also looks like you didn't change the code style at all (indentation, newlines, etc.) to match surrounding code, as I requested last time. |
karanbhatt16
changed the title
88154c9 to
5f90b2f
Compare
|
Thanks for catching those. I've updated the PR title and description to match the current change and cleaned up the code style to be consistent with the surrounding code. I've pushed the updated changes and re-requested review. |
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Please do another careful self-review before resubmitting.
07b9800 to
97d3ba0
Compare
karanbhatt16
changed the title
97d3ba0 to
f4c05e8
Compare
Add an optional illustration widget to PageBodyEmptyContentPlaceholder and use it for the empty inbox placeholder. Fixes zulip#1551.
f4c05e8 to
103bd3f
Compare
|
Thank you for the feedback. I've carefully reviewed the implementation again, Could you please take another look.. |
2 participants
Fixes #1551
Implemented Figma designs for Inbox, Channels, and Direct Messages by Extending the PageBodyEmptyContentPlaceholder to support customizable illustrations and trailing graphics so different pages can display their own design
Added vector graphic assets under:
assets/images/
These assets provide the empty-state illustrations used by the Inbox, Channels, and Direct Messages pages.