api: Don't allow connecting to servers <5.0; show nag banner on <7.0 #5920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-show-nag-banner-on-5.x
branch
from
022a966 to
3fa3e37
Compare
chrisbobbe
changed the title
chrisbobbe
changed the title
chrisbobbe
force-pushed
the
pr-show-nag-banner-on-5.x
branch
from
3fa3e37 to
878252c
Compare
See 8552afc for the previous one of these. The Zulip Server 5 release went out over 3 years ago, so the 4.x releases are all long out of our announced 18-month compatibility window: https://blog.zulip.com/2022/03/29/zulip-5-0-released/ https://zulip.readthedocs.io/en/latest/overview/release-lifecycle.html#client-apps So we can cheerfully refuse to connect to 4.x releases; our "Server not supported" nag banner has been asking server admins on those versions to upgrade since 8552afc, which the changelog says went out in v27.216, dated 2023-10-10. The last 6.x release, 6.2, went out on 2023-05-19. That's also outside the 18-month window, so it's time to start showing the nag banner on 5.x and 6.x. The last 7.x release, 7.5, went out on 2023-11-16, which is a month and a bit shy of 18 months, so it's not yet time to show the banner for versions 7.x.
chrisbobbe
force-pushed
the
pr-show-nag-banner-on-5.x
branch
from
878252c to
48f1e47
Compare
|
Thanks for taking care of this! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The branch is misnamed; I realized after writing it that we can show the nag banner on 6.x too. 🙂)