Keypress Rules Refactor: Buttons #1117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rohitth007
force-pushed
the
keypress-rules-1
branch
from
f38722c to
91fa7ea
Compare
Rohitth007
force-pushed
the
keypress-rules-1
branch
3 times, most recently
from
9fb1700 to
5a1ebb3
Compare
4 tasks
This commit adds spaces after each keypress conditional to improve readability and consistency across all keypress'.
Rohitth007
force-pushed
the
keypress-rules-1
branch
from
5a1ebb3 to
4fe9869
Compare
Rohitth007
force-pushed
the
keypress-rules-1
branch
from
4fe9869 to
4c84735
Compare
This commit refactors keypress to follow urwid rules, i.e., * send key to inner-most widget. * handle unhandled keys from super() and return None. * return unhandled keys. Intercepted keys: * " " (space) is not sent to super() in TopButton as it an ACTIVATE key and we already have ENTER. Tests updated.
Rohitth007
force-pushed
the
keypress-rules-1
branch
from
4c84735 to
4c33fc3
Compare
|
Heads up @Rohitth007, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the first of the keypress rules refactors which refactors Buttons.
The idea of following keypress rules is to:
Tested?
Commit flow
The first commit adds spaces to improve consistency between all keypress' and improve readability.
The second one does the actual keypress refactor for Buttons.