Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add last active to the PM window, and add more features to PMs. #1184

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

plugyawn
Copy link
Collaborator

@plugyawn plugyawn commented Apr 3, 2022

What does this PR do?
Aims to add a few more features to the PM window, such as adding a last active message.

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

  • added the last active message.

Notes & Questions
What more could we add to the PM Window?

Interactions

Visual changes

@zulipbot zulipbot added the size: S [Automatic label added by zulipbot] label Apr 3, 2022
@neiljp
Copy link
Collaborator

neiljp commented Apr 3, 2022

@plugyawn I'd recommend discussing this on the stream before going too far into this.

The equivalent detail we've discussed previously would be a summary of this via an extension of the message list version which shows the user presence markers (which is not in the web app). The web app has that in the autocomplete/typeahead equivalent, though not in the compose box itself during the rest of composing of PMs. That would basically be part of #1155 for the summary data for what you're looking at here.

@plugyawn
Copy link
Collaborator Author

plugyawn commented Apr 4, 2022

Okay!

The last seen thing was something that was commonplace on messenger applications, and it's a pretty handy indicator to have, so I guessed it's useful to have it here, too.

Also attaching an image for general reference.

Screenshot 2022-04-04 at 8 50 17 AM

@zulipbot
Copy link
Member

Heads up @plugyawn, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts size: S [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants