Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List topics under stream-name when narrowed. #1191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

plugyawn
Copy link
Collaborator

@plugyawn plugyawn commented Apr 9, 2022

What does this PR do?
Shows topics under stream-name when narrowed to.

Fixes most of #1190.

https://chat.zulip.org/#narrow/stream/206-zulip-terminal/topic/Panel-follows-narrow.20.23T1190

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

  • first commit adds the new function for showing the view when a stream is narrowed to.

Notes & Questions

  • doesn't include stream highlighting.
  • might be difficult to discern topics from streams.

Interactions

Visual changes
Screenshot 2022-04-10 at 5 10 18 AM

Wrote new function for dealing with streams when they're narrowed to; these streams will have the first N recent topics listed.
@zulipbot zulipbot added the size: L [Automatic label added by zulipbot] label Apr 9, 2022
@plugyawn
Copy link
Collaborator Author

plugyawn commented Apr 9, 2022

@neiljp @prah23 could you provide some feedback on this, please?

@neiljp
Copy link
Collaborator

neiljp commented Apr 10, 2022

@plugyawn See discussion in the stream.

@zulipbot
Copy link
Member

Heads up @plugyawn, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts size: L [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants