-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
views: Add footer to StreamsView and TopicsView #1199
base: main
Are you sure you want to change the base?
Conversation
@plugyawn Thanks for exploring this 👍 See my thoughts in the stream, since this is mainly visual so we may want to discuss rather than focus on implementation. |
@neiljp implemented the theming change. Is it clearer to look at now? |
@zulipbot add "PR needs review" |
Feedback was given in the stream. |
Added the shortcut hint for displaying Topics to the Streams Panel and a hint to get back to Streams in the Topics Panel.
9771985
to
7958751
Compare
@plugyawn You didn't change the labels on this, though have pushed since we last reviewed. I left a note in the stream. |
Oh, I just fixed the commit text for the PR, didn't add anything new, so I didn't change the labels. |
Heads up @plugyawn, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
What does this PR do?
Added the shortcut hint for displaying Topics to the Streams Panel and a hint to get back to Streams in the Topics Panel.
Associated with #1190. Discussed on CZO at Stream/topic toggle hint?
Tested?
Commit flow
Notes & Questions
t
, so have to fix that.Visual changes
