Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add feature to toggle subscription #1266

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mounilKshah
Copy link
Collaborator

What does this PR do?
This PR is to add subscribe-unsubcribe toggle for all streams present in the stream.
Currently, the commit in the PR only works for a single stream.
Partial fix for #570

Discussion topic:
zulip-terminal>Add provision to subscribe to streams

Shifted from #1240 to here.

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behaviour)
  • Passed linting & tests (each commit)

Commit flow

  • Popup for subscribe/unsubscribe toggle

Notes & Questions

  • Works only for one stream and it has to be in the same session. Needs to be extended to all streams
  • Does not update the stream view, nor the messages in the MiddleColumn

Visual changes

  • To be added

This is a temporary commit used in order to rebase the branch
to the active state of the remote repository.
@zulipbot zulipbot added the size: L [Automatic label added by zulipbot] label Oct 15, 2022
@zulipbot
Copy link
Member

Heads up @mounilKshah, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts size: L [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants