Prevent message merging when starred #1340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the condition for difference in messages from comparing to outright assigning the status of the current message to prevent merging of messages starred in a row fixes zulip#171
Sushmey
force-pushed
the
starred-messages
branch
from
13c3537 to
d9604b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR #1147 was meant to fix #171 but had some coverage issues with the test cases. This PR helps to resolve that
Tested?
Commit flow
First commit: Improving the test case so we can see the initial code doesn't pass the test cases
Second commit: Adding better condition to check star status difference
Notes & Questions
Interactions
Visual changes