Upgrade Mypy from 1.3.x to 1.8.x #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
force-pushed
the
2024-01-25-mypy-upgrade
branch
3 times, most recently
from
16c0eac to
f19a2cc
Compare
neiljp
force-pushed
the
2024-01-25-mypy-upgrade
branch
from
9f94611 to
6e6f035
Compare
zulipbot
added
size: M
neiljp
force-pushed
the
2024-01-25-mypy-upgrade
branch
6 times, most recently
from
61f1d50 to
4a963c2
Compare
This appeared to work previously when used in CI, but installation gives a WARNING regarding not finding the extra.
Python 3.7 is now end of life. Core libraries will increasingly drop support, but we can certainly push development requirements more rapidly, and newer mypy already requires 3.8.
The strict-concatenate option is now deprecated, so replaced by extra-checks, in pyproject.toml.
This requires an update of a type ignore in convert-unicode-emoji-data, which is necessary due to the imported file being conditionally present. CI and local Python 3.9 require different type ignore specifiers, so this also adds 'unused-ignore', to avoid errors when the other type ignore is apparently not used on the other platform.
neiljp
force-pushed
the
2024-01-25-mypy-upgrade
branch
from
4a963c2 to
7e90e08
Compare
neiljp
added
the
PR ready to be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
This results in a more featureful, fast and less buggy version of mypy - it certainly appears to be faster so far.
This PR upgrades mostly by individual minor versions, to incorporate minor fixes found to be necessary for each upgrade.
This also refactors the lint-and-test workflow to use a common python version for linting explicitly, which is then easily bumped to 3.8 for mypy 1.5.x.
The initial commit is a CI bugfix to enable the test minimal-dependencies for mypy, added in #1461.
Outstanding aspect(s)
External discussion & connections
topicHow did you test this?
Self-review checklist for each commit