bugfix: messages: Fix crash when editing message #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Young-Lord Thanks for finding the bug and providing this fix! :) I can add a test case for this situation before merging, unless you wish to do so? |
|
I don't know how to add a test case, so maybe you can do that. |
|
No problem :) |
When `realm_message_content_edit_limit_seconds` is None, which now means no time limit for editing messages, ZT crashes with a `TypeError`. This was diagnosed in Zulip cloud, but may be triggered for any version of the server from feature level 138, which was released first in Zulip server 6.0. Prior to this feature level, no limit on editing messages was represented by a numerical value of zero; a direct numerical comparison was therefore possible, but now causes an error. Fixes #1467.
Confirmed as failing, if prior to the contributed bugfix in the previous commit.
zulipbot
added
size: M
|
@Young-Lord Thanks again for finding and fixing! I slightly updated your commit text, and added a commit which covers testing of the new behavior, and am merging now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
When
realm_message_content_edit_limit_secondsis None, which means no time limit for editing message, ZT crashes withTypeError.This happens in Zulip cloud server.
This PR fix it.
External discussion & connections
topicHow did you test this?
Self-review checklist for each commit