Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for deprecating reactions' user metadata #1556

Merged
merged 9 commits into from
Dec 10, 2024
Merged

Preparation for deprecating reactions' user metadata #1556

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4765327
refactor: model/views: Simplify functions handling message reactions.
Niloth-p Nov 17, 2024
d9cd5e5
api_types/model: Add support for `user_id` in reaction events.
Niloth-p Nov 17, 2024
e037dc4
test_model: Align reactions schema with Get Message API endpoint.
Niloth-p Nov 17, 2024
f7e56c9
bugfix: model: Remove the reaction corresponding to the reaction event.
Niloth-p Nov 17, 2024
911f8ee
model: Convert reaction events to message reactions schema.
Niloth-p Nov 17, 2024
35d5bee
model: Add get_user_id_from_reaction for messages and reaction events.
Niloth-p Nov 18, 2024
6e2f98c
test_model: Add user_id test cases for reaction factories.
Niloth-p Nov 17, 2024
198e8f3
test_model: Add varied test cases for testing reaction event handling.
Niloth-p Nov 18, 2024
005dabb
messages/views: Prepare for the deprecation of user metadata.
Niloth-p Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions zulipterminal/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1849,9 +1849,20 @@ def _handle_reaction_event(self, event: Event) -> None:
)
else:
for reaction in message["reactions"]:
# Since Who reacted is not displayed,
# remove the first one encountered
if reaction["emoji_code"] == event["emoji_code"]:
reaction_user_id = (
reaction["user"]["id"]
if "user" in reaction
else reaction["user_id"]
)
event_user_id = (
event["user"]["user_id"]
if event.get("user") and isinstance(event["user"], dict)
else event["user_id"]
)
if (
reaction["emoji_code"] == event["emoji_code"]
and reaction_user_id == event_user_id
):
message["reactions"].remove(reaction)
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature level 3.0 is old enough that we could drop support for it. But I guess this is OK.


Expand Down