-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate server connectivity via heartbeat #276
base: main
Are you sure you want to change the base?
Indicate server connectivity via heartbeat #276
Conversation
|
Amend tests.
Also add method to update the time, with test.
7557a4d
to
72497e9
Compare
@amanagr I understand there are concerns regarding this PR, and didn't expect it to be an easy merge :) I am open to suggestions on a shorter format for the 'server contact' details. I think it could be confusing to a user to indicate server connection/status through user status:
|
If we only want to show how recently things were updated, we can use Then change it to Also, note that it make ZT look like something which updates itself on constant intervals rather than something being continuously updated. 😅 (Not a concern for now BTW) |
I left it as just the time, as it wasn't clear to me at this point what 'go wrong' means, though I appreciate that 'updated' is simpler, if not necessarily any clearer. |
Heads up @neiljp, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
This PR uses the automatic heartbeat event from the server to show the connectivity status in the bottom-right of the application.
Note that although the window says "Last server contact", this only updates on heartbeat events; we can change this to be more expressive/accurate, eg. trigger on every server event, or specifically say 'heartbeat' or similar.
I'm not sure that we handle reconnecting properly, but this gives an indication of whether things should be working, visually, which is perhaps not always obvious.