bugfixes: Improve first/last message handling #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dict tracks whether the app has the last message in a narrow; this commits fixes the following issues: * There are too many narrows to pre-populate the dict, so ensure we use `.get` when checking it upon receiving a message event. * The value for a narrow was set on each get_message call, but the value from a call is whether the returned messages contain the last message, so use both the previous state (if any) as well as the new state.
Prior to this commit, pressing GO_DOWN at the bottom of a message view in which there were no more messages would hit the API each time, looking for newer messages. With the consistent new-message tracking now present in the model, a new model accessor then supports determining this state, avoiding scrolling and fetching newer messages if not required.
Prior to this commit, pressing GO_UP at the top of a message view in which there were no more messages would hit the API each time, looking for older messages. If the oldest message in a narrow is reached, this is now tracked in the model much like tracking the last message (the API uses found_[oldest|newest]). A new model accessor then supports determining this state, avoiding scrolling and fetching older messages if not required.
|
These tests may be fixed by rebasing onto something like #904. I've run with this branch a little and am slightly concerned that this has or exposes an outstanding issue with movement between eg. stream and topic narrows, but makes it worse since it may limit the scrolling. Further thoughts welcome! |
|
Heads up @neiljp, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of exploring seeing intermittent cases where the
_have_last_messagedict had aKeyErrorin event handling via the new Notice popup.This PR:
This is a partial fix of #428, in particular #428 (comment).