Dependencies: Add Zulint. #980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhirup-99
force-pushed
the
add_zulint
branch
7 times, most recently
from
90e5678 to
e8f5164
Compare
zulipbot
added
size: M
zulipbot
added
size: XL
|
@zulipbot add "PR needs review" |
|
Changes in the pr:
|
The commit integrates zulint in the linting infrastructure. The code structure for lint-all has been taken from python api, and modified for our needs.
The lister.py was a custom script for file reading operations. The commit replaces it with inbuilt functions from zulint.
The commit removes individual steps to run mypy, isort and flake8, and replaces it with a matrix to run them through zulint.
The commit updates generate_hotkeys and gitlint_extra_rules to remove errors from flake8, bringing them under linting.
The commit modifies the behaviour of running lint, printing a successful message on completion of flake8 linter. The original script didn't produce any output on success.
|
@Abhirup-99 I see you're not on chat.zulip.org and I'm guessing you're busy in the near future, but just checking if you plan to take this up again soon before I pick this up myself or suggest it to someone else. |
|
Hi, I am a bit busy now, it would be better if someone else takes the work forward. |
|
Heads up @Abhirup-99, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.