Skip to content

feat: Use the HARD_SPLIT_FROM_SERVER code to followup uniffle impl #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zuston merged 1 commit into from
Dec 10, 2025
Merged

feat: Use the HARD_SPLIT_FROM_SERVER code to followup uniffle impl #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions riffle-server/src/constant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ pub enum StatusCode {
// to indicate shuffle-writing not retry!
// todo: we should introduce the dedicated status code to indicate this
EXCEED_HUGE_PARTITION_HARD_LIMIT = 12,
HARD_SPLIT_FROM_SERVER = 15,
}

impl Into<i32> for StatusCode {
Expand Down
5 changes: 5 additions & 0 deletions riffle-server/src/grpc/protobuf/uniffle.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,11 @@ enum StatusCode {
ACCESS_DENIED = 8;
INVALID_REQUEST = 9;
NO_BUFFER_FOR_HUGE_PARTITION = 10;
STAGE_RETRY_IGNORE = 11;
EXCEED_HUGE_PARTITION_HARD_LIMIT = 12;
APP_NOT_FOUND = 13;
INTERNAL_NOT_RETRY_ERROR = 14;
HARD_SPLIT_FROM_SERVER = 15;
// add more status
}

Expand Down
2 changes: 1 addition & 1 deletion riffle-server/src/grpc/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ impl ShuffleServer for DefaultShuffleServer {
vec![],
),
Err(WorkerError::WRITE_LIMITED_BY_STORAGE_STATE) => (
StatusCode::EXCEED_HUGE_PARTITION_HARD_LIMIT,
StatusCode::HARD_SPLIT_FROM_SERVER,
-1i64,
"".to_string(),
vec![],
Expand Down