feat: add sdkVersion to NodeState, bump schema to 42#1420
Merged
Conversation
raman325
approved these changes
Apr 30, 2025
Collaborator
There was a problem hiding this comment.
this works, thank you, but two quick thoughts:
- I don't remember why but at some point I endedf up creating types for NodeState for every schema version, even if it was a replica of the previous version. We should probably be consistent whether we remove those or add the ones in between 35 and 42. Not needed for this PR though
- Generally speaking, the node state dumping logic is messy. Is there any way to clean it up? Not a major issue and can be done in a separate PR, but it would be nice to make that function more maintainable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that the node dump did not include this field, although the driver makes it available.