Skip to content

feat: add sdkVersion to NodeState, bump schema to 42#1420

Merged
AlCalzone merged 1 commit into
masterfrom
node-state-sdk-version
May 5, 2025
Merged

feat: add sdkVersion to NodeState, bump schema to 42#1420
AlCalzone merged 1 commit into
masterfrom
node-state-sdk-version

Conversation

@AlCalzone
Copy link
Copy Markdown
Member

@AlCalzone AlCalzone commented Apr 29, 2025

We noticed that the node dump did not include this field, although the driver makes it available.

Copy link
Copy Markdown
Collaborator

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, thank you, but two quick thoughts:

  1. I don't remember why but at some point I endedf up creating types for NodeState for every schema version, even if it was a replica of the previous version. We should probably be consistent whether we remove those or add the ones in between 35 and 42. Not needed for this PR though
  2. Generally speaking, the node state dumping logic is messy. Is there any way to clean it up? Not a major issue and can be done in a separate PR, but it would be nice to make that function more maintainable

@AlCalzone AlCalzone merged commit 1bba218 into master May 5, 2025
1 check passed
@AlCalzone AlCalzone deleted the node-state-sdk-version branch May 5, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants