Preserve existing log transports when modifying log config#1559
Merged
Conversation
Agent-Logs-Url: https://github.com/zwave-js/zwave-js-server/sessions/41b65fa9-b29f-49d3-b256-27c32ef057cf Co-authored-by: AlCalzone <17641229+AlCalzone@users.noreply.github.com>
Agent-Logs-Url: https://github.com/zwave-js/zwave-js-server/sessions/41b65fa9-b29f-49d3-b256-27c32ef057cf Co-authored-by: AlCalzone <17641229+AlCalzone@users.noreply.github.com>
Agent-Logs-Url: https://github.com/zwave-js/zwave-js-server/sessions/41b65fa9-b29f-49d3-b256-27c32ef057cf Co-authored-by: AlCalzone <17641229+AlCalzone@users.noreply.github.com>
Agent-Logs-Url: https://github.com/zwave-js/zwave-js-server/sessions/41b65fa9-b29f-49d3-b256-27c32ef057cf Co-authored-by: AlCalzone <17641229+AlCalzone@users.noreply.github.com>
Agent-Logs-Url: https://github.com/zwave-js/zwave-js-server/sessions/41b65fa9-b29f-49d3-b256-27c32ef057cf Co-authored-by: AlCalzone <17641229+AlCalzone@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix zwavejs logging to file issue with websocket
Preserve existing driver log transports when websocket logging is enabled
May 19, 2026
AlCalzone
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
zwave-js-serverenabled websocket log streaming or accepted websocket log config updates, it could replace the driver's existing transport list. In setups where another host application had already registered transports on the shared driver, those transports could disappear and file logging would not recover.Root cause
update_log_configcalls were passed through with the client-providedtransportsarray, allowing remote clients to overwrite transports owned by the embedding application.Server-side transport preservation
transportsand only applies the other requested log config fields.update_log_configpaths so transport ownership stays with the host application.Logging forwarder behavior
Regression coverage
driver.start_listening_logsdriver.update_log_configdriver.stop_listening_logs