Skip to content

Conversation

0zero-r
Copy link
Contributor

@0zero-r 0zero-r commented Jun 25, 2025

No description provided.

@zxh326 zxh326 requested a review from Copilot June 25, 2025 17:00
@zxh326 zxh326 changed the title feat: add 'Ready' column to PodTable and support hiddenNode prop feat: add Ready column to PodTable and support hiddenNode prop Jun 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a “Ready” column to the PodTable, introduces a hiddenNode prop to conditionally hide the Node column, and switches to a shared formatDate helper for pod creation timestamps.

  • Introduce hiddenNode boolean prop and pass it from NodeDetail
  • Add “Ready” column showing how many containers are ready
  • Replace inline toLocaleString with formatDate and update memo dependencies

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ui/src/pages/node-detail.tsx Pass hiddenNode prop into <PodTable>
ui/src/components/pod-table.tsx Add hiddenNode prop, inject “Ready” column, hide Node column when hiddenNode is true, use formatDate, update memo deps
Comments suppressed due to low confidence (3)

ui/src/components/pod-table.tsx:19

  • [nitpick] The prop name hiddenNode is a bit ambiguous; consider renaming to hideNodeColumn to more clearly convey that it toggles hiding the Node column.
  hiddenNode?: boolean

ui/src/components/pod-table.tsx:78

  • New “Ready” column logic isn’t covered by existing tests; consider adding unit or integration tests to validate the ready count formatting and display.
        header: 'Ready',

ui/src/components/pod-table.tsx:21

  • [nitpick] Consider destructuring hiddenNode along with pods and isLoading for consistency, e.g. const { pods, isLoading, hiddenNode } = props;
  const { pods, isLoading } = props

@zxh326 zxh326 merged commit 79d0742 into zxh326:main Jun 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants