Skip to content

Conversation

zxh326
Copy link
Owner

@zxh326 zxh326 commented Sep 24, 2025

No description provided.

Copy link

github-actions bot commented Sep 24, 2025

🐳 Docker image built successfully!

Image: ghcr.io/zxh326/kite:pr-153

@zxh326 zxh326 changed the title refactor describer feat: support describe everything Sep 24, 2025
@zxh326 zxh326 changed the title feat: support describe everything feat: support describe every resources Sep 24, 2025
@zxh326 zxh326 requested a review from Copilot September 24, 2025 15:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a unified "Describe" functionality across all Kubernetes resource detail pages by creating a reusable DescribeDialog component and implementing comprehensive backend support for the kubectl describe operation.

  • Creates a centralized DescribeDialog component that replaces inline describe implementations
  • Implements generic describe functionality in backend handlers for all resource types including custom resources
  • Refactors existing pod and node describe implementations to use the new unified approach

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ui/src/components/describe-dialog.tsx New reusable dialog component for kubectl describe functionality
ui/src/pages/*.tsx Replace inline describe implementations with the new DescribeDialog component
pkg/handlers/resources/generic_resource_handler.go Add generic describe method using kubectl's describe package
pkg/handlers/resources/cr_handler.go Add describe support for custom resources
pkg/handlers/resources/handler.go Add describe routes for all resources
pkg/handlers/resources/*_handler.go Remove old describe implementations from pod and node handlers
pkg/kube/client.go Export scheme for use in describe functionality
scripts/*.sh Add utility scripts for git hooks and version management
Makefile Update version generation to use new script

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Refresh
</Button>
<DescribeDialog
resourceType={'jobs'}
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceType prop should not be wrapped in unnecessary braces. Use resourceType="jobs" for consistency with other files.

Suggested change
resourceType={'jobs'}
resourceType="jobs"

Copilot uses AI. Check for mistakes.

Refresh
</Button>
<DescribeDialog
resourceType={'daemonsets'}
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceType prop should not be wrapped in unnecessary braces. Use resourceType="daemonsets" for consistency with other files.

Suggested change
resourceType={'daemonsets'}
resourceType="daemonsets"

Copilot uses AI. Check for mistakes.

Refresh
</Button>
<DescribeDialog
resourceType={'cronjobs'}
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceType prop should not be wrapped in unnecessary braces. Use resourceType="cronjobs" for consistency with other files.

Suggested change
resourceType={'cronjobs'}
resourceType="cronjobs"

Copilot uses AI. Check for mistakes.

@zxh326 zxh326 merged commit a346b6d into main Sep 24, 2025
3 checks passed
@zxh326 zxh326 deleted the more-describer branch September 24, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant