-
Notifications
You must be signed in to change notification settings - Fork 82
feat: support describe every resources #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Zzde <[email protected]>
🐳 Docker image built successfully! Image: |
Signed-off-by: Zzde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a unified "Describe" functionality across all Kubernetes resource detail pages by creating a reusable DescribeDialog
component and implementing comprehensive backend support for the kubectl describe operation.
- Creates a centralized
DescribeDialog
component that replaces inline describe implementations - Implements generic describe functionality in backend handlers for all resource types including custom resources
- Refactors existing pod and node describe implementations to use the new unified approach
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
ui/src/components/describe-dialog.tsx | New reusable dialog component for kubectl describe functionality |
ui/src/pages/*.tsx | Replace inline describe implementations with the new DescribeDialog component |
pkg/handlers/resources/generic_resource_handler.go | Add generic describe method using kubectl's describe package |
pkg/handlers/resources/cr_handler.go | Add describe support for custom resources |
pkg/handlers/resources/handler.go | Add describe routes for all resources |
pkg/handlers/resources/*_handler.go | Remove old describe implementations from pod and node handlers |
pkg/kube/client.go | Export scheme for use in describe functionality |
scripts/*.sh | Add utility scripts for git hooks and version management |
Makefile | Update version generation to use new script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Refresh | ||
</Button> | ||
<DescribeDialog | ||
resourceType={'jobs'} |
Copilot
AI
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resourceType prop should not be wrapped in unnecessary braces. Use resourceType="jobs"
for consistency with other files.
resourceType={'jobs'} | |
resourceType="jobs" |
Copilot uses AI. Check for mistakes.
Refresh | ||
</Button> | ||
<DescribeDialog | ||
resourceType={'daemonsets'} |
Copilot
AI
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resourceType prop should not be wrapped in unnecessary braces. Use resourceType="daemonsets"
for consistency with other files.
resourceType={'daemonsets'} | |
resourceType="daemonsets" |
Copilot uses AI. Check for mistakes.
Refresh | ||
</Button> | ||
<DescribeDialog | ||
resourceType={'cronjobs'} |
Copilot
AI
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resourceType prop should not be wrapped in unnecessary braces. Use resourceType="cronjobs"
for consistency with other files.
resourceType={'cronjobs'} | |
resourceType="cronjobs" |
Copilot uses AI. Check for mistakes.
No description provided.