feat: persist log viewer tail lines setting to localStorage #158
+29
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Successfully implemented localStorage persistence for the log viewer tail lines setting to address the user experience issue where users had to adjust the display line count every time they viewed logs.
Implementation Details
Problem: The tail lines setting (日志默认显示行数) was hardcoded to 100 and not persisted, requiring users to adjust it manually each time.
Solution: Added localStorage persistence following the same pattern used by other log viewer settings:
localStorage.getItem('log-viewer-tail-lines')
with fallback to 100handleTailLinesChange
that updates both state and localStorageKey Features:
Testing: Validated through type checking, linting, building, and localStorage functionality testing. The implementation correctly saves and retrieves values, solving the user experience issue.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.