Skip to content

Formatter: resolve PADDING_AUTO for signed immediates in print_imm #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mappzor merged 1 commit into from
Jun 4, 2026
+11 −10
Merged

Formatter: resolve PADDING_AUTO for signed immediates in print_imm #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions src/FormatterBase.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,16 +323,6 @@ ZyanStatus ZydisFormatterBasePrintIMM(const ZydisFormatter* formatter,

ZYDIS_BUFFER_APPEND_TOKEN(buffer, ZYDIS_TOKEN_IMMEDIATE);

const ZyanBool is_signed =
(formatter->imm_signedness == ZYDIS_SIGNEDNESS_SIGNED) ||
(formatter->imm_signedness == ZYDIS_SIGNEDNESS_AUTO && (context->operand->imm.is_signed));
if (is_signed && (context->operand->imm.value.s < 0))
{
ZYDIS_STRING_APPEND_NUM_S(formatter, formatter->imm_base, &buffer->string,
context->operand->imm.value.s, formatter->imm_padding,
formatter->hex_force_leading_number, ZYAN_FALSE);
return ZYAN_STATUS_SUCCESS;
}
ZyanU64 value;
ZyanU8 padding = (formatter->imm_padding ==
ZYDIS_PADDING_AUTO) ? 0 : (ZyanU8)formatter->imm_padding;
Expand Down Expand Up @@ -369,6 +359,17 @@ ZyanStatus ZydisFormatterBasePrintIMM(const ZydisFormatter* formatter,
default:
return ZYAN_STATUS_INVALID_ARGUMENT;
}

const ZyanBool is_signed =
(formatter->imm_signedness == ZYDIS_SIGNEDNESS_SIGNED) ||
(formatter->imm_signedness == ZYDIS_SIGNEDNESS_AUTO && (context->operand->imm.is_signed));
if (is_signed && (context->operand->imm.value.s < 0))
{
ZYDIS_STRING_APPEND_NUM_S(formatter, formatter->imm_base, &buffer->string,
context->operand->imm.value.s, padding,
formatter->hex_force_leading_number, ZYAN_FALSE);
return ZYAN_STATUS_SUCCESS;
}
ZYDIS_STRING_APPEND_NUM_U(formatter, formatter->imm_base, &buffer->string, value, padding,
formatter->hex_force_leading_number);

Expand Down
Loading