build: add noble as base image

zydou · Jun 21, 2024 · 0ba6373 · 0ba6373
1 parent 2e5155b
commit 0ba6373
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/build-base-image.yml b/.github/workflows/build-base-image.yml
@@ -21,7 +21,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        base_os: [buster, bullseye, bookworm, trixie, xenial, bionic, focal, jammy]
+        base_os: [buster, bullseye, bookworm, trixie, xenial, bionic, focal, jammy, noble]
     name: Build base image on ${{ matrix.base_os }}
     runs-on: ubuntu-latest
     steps:

diff --git a/base.Dockerfile b/base.Dockerfile
@@ -13,8 +13,8 @@ SHELL ["/bin/bash", "-c"]
 # modified from https://gitlab.com/islandoftex/images/texlive/-/blob/master/Dockerfile.base
 RUN apt-get update -qq && \
     # handling special cases
-    # libncurses5 is missing on Debian trixie
-    if [[ "${OS_VARIANT}" != "trixie-slim" ]]; then apt-get install -qq -y --no-install-recommends --no-upgrade libncurses5; fi && \
+    # libncurses5 is missing on trixie and noble
+    if [[ "${OS_VARIANT}" != "trixie-slim" && "${OS_VARIANT}" != "noble" ]]; then apt-get install -qq -y --no-install-recommends --no-upgrade libncurses5; fi && \
     # libncurses6 is missing on Ubuntu xenial and bionic
     if [[ "${OS_VARIANT}" != "xenial" && "${OS_VARIANT}" != "bionic" ]]; then apt-get install -qq -y --no-install-recommends --no-upgrade libncurses6; fi && \
     # basic utilities for TeX Live installation