Fix Dreo websocket command bursts#117
Open
machina86 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unreliable Dreo fan scene/automation behavior when multiple fans are controlled at the same time.
HomeKit scenes can send several Dreo control commands in a very short burst, especially when turning fans on or changing speed. I had mlutiple DR-HPF004S fans in a scene that would turn off together but would fail to turn on and I had a DR-HCF003S fan that had unreliable speed updates in automations.
This change serializes outgoing Dreo websocket control commands through a shared queue and adds a short delay between sends.
Changes
DreoAPI.control().webHelper.control(...).4.3.0to4.3.1but you can ignore that depending on if and when you merge thisTesting
Validated on a Raspberry Pi Homebridge image with multiple Dreo fans:
control-replyandcontrol-reportresponses for each fan after scene activation.