[pull] main from fastify:main #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: fix TypeScript inconsistency in Decorators.md - Remove TypeScript generic syntax from getDecorator and setDecorator sections - Convert all TypeScript examples to JavaScript for consistency - Simplify complex TypeScript-specific concepts - Maintain JavaScript style used throughout the rest of the document Fixes #6222 * docs: revise approach based on maintainer feedback - Move TypeScript-specific decorator content to TypeScript.md instead of deleting - Keep JavaScript-focused documentation in Decorators.md consistent with rest of document - Add comprehensive TypeScript decorators section with advanced typing examples - Preserve valuable information while addressing the original inconsistency issue Addresses feedback from jean-michelet and jsumners on PR #6224 * fix: resolve markdown linting issues - Fix line length violations in docs/Reference/Decorators.md - Fix line length violations in docs/Reference/TypeScript.md - All lines now comply with 80 character limit - Addresses linting feedback from PR review * fix: address PR feedback from jean-michelet - Remove 'Plugin encapsulation' bullet point from Decorators.md - Consolidate overlapping bullet points into single 'Dependency validation' point - Move TypeScript Decorators section under Plugins section as requested - Change heading level from ### to #### for proper nesting Addresses feedback from PR review comments * fix: address PR feedback from Fdawgs - Remove second-person 'you' usage from TypeScript decorators section - Change **Note**: format to ℹ Note: format - Remove redundant 'Use Cases' sections and consolidate content - Addresses feedback from PR review comments * Update docs/Reference/TypeScript.md Signed-off-by: Frazer Smith <[email protected]> * docs: update TypeScript decorators section for enhanced type safety Refactor the documentation for Fastify's `getDecorator<T>` and `setDecorator<T>` methods to emphasize their support for generic type parameters, improving type safety and TypeScript integration. This change clarifies the usage of decorators in Fastify and links to the relevant Decorators reference. * fix: address final review feedback from jean-michelet - Simplify setDecorator description in TypeScript.md - Simplify getDecorator description in TypeScript.md - Streamline setDecorator note in Decorators.md Resolves all unresolved review comments to unblock PR merge. * fix linting --------- Signed-off-by: Frazer Smith <[email protected]> Co-authored-by: Frazer Smith <[email protected]> Co-authored-by: Jean <[email protected]> Co-authored-by: Aras Abbasi <[email protected]>
github-actions
bot
added
the
documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )