[pull] canary from vercel:canary #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Why? There's a typo missing `s` in `errors` in the area attribute in `BuildError` component ```diff - aria-labelledby="nextjs__container_error_label" + aria-labelledby="nextjs__container_errors_label" ```
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change Closes NEXT- Fixes # --> ### What? `x-deployment-id` is missing on prefetch requests ### Why? To handle version skew on the pages router. When version skew is turned on, `x-deployment-id` should be used on prefetch otherwise the server will return 404. But with middleware enabled, the 404 does not appear to hard-refresh the page. ### How? next.js seems to be relying on the 404 to perform a _hard_ navigation and auto-refresh the client. But that doesn't appear to happen when middleware is in use (separate issue, not addressed in this PR), which is causing the client to navigate to 404 whenever we deploy a new version of the site to vercel. instead of sending the client to 404, passing the `x-deployment-id` helps guarantee that next-data requests respect version skew protection. --------- Co-authored-by: JJ Kasper <[email protected]>
…74067) ## Description This PR updates the [`with-mdx-remote`](https://github.com/vercel/next.js/tree/canary/examples/with-mdx-remote) example to use the App Router and TypeScript. Here are the changes that have been made: 1. Renamed the `pages` folder to the `app` folder. 2. Converted JavaScript to TypeScript files and created `tsconfig.json`. 3. Created a new `global.css` and `layout.tsx` files in the app directory. 4. Used [CSS module](https://github.com/css-modules/css-modules) instead of [styled-jsx](https://github.com/vercel/styled-jsx). 5. Removed [`next-remote-watch`](https://github.com/hashicorp/next-remote-watch) due to incompatibility and no maintenance. 6. Removed [`gray-matter`](https://github.com/jonschlinkert/gray-matter) and implement front-matter parser as well. 7. Updated the `.gitignore`, `package.json` and README.md files. The new app looks and works much the same as the old one. ### Adding or Updating Examples - [x] The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - [x] Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md --------- Co-authored-by: Sam Ko <[email protected]>
This pull request removes duplication of a utility function within the `with-supabase` example as mentioned in the following issue #73942 - I removed the duplicated code from the `utils` directory as when shadcn installs a new component, that component will look for the helper function in `lib/utils.ts` and forcing users to update every component after installation or modify any config files for shadcn seems like a worse DX. - Fixes #73942 --------- Co-authored-by: samcx <[email protected]>
we've seen these tests flake with this error:
```
expect(received).toBe(expected) // Object.is equality
Expected: 0
Received: null
234 | // App finally shuts down
235 | await appKilledPromise
> 236 | expect(app.exitCode).toBe(0)
| ^
237 | })
238 | })
239 | }
at Object.toBe (production/graceful-shutdown/index.test.ts:236:
```
this PR doesn't fix that, but it should make it easier to see why the
code was `null` -- if signal is nonnull, we'll see what it was.
note: `once(app, 'exit')` returns the arguments passed to the `exit`
callback, which are `(code, signal)`
This pull request adds telemetry collection for error message feedback in the development server. It exposes an internal endpoint `/__nextjs_error_feedback` for the error overlay to call. https://linear.app/vercel/issue/NDX-597/create-error-feedback-ui-that-fires-events-to-next-telemetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )