[pull] canary from vercel:canary #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`is-error` is a helper that being used accorss client and server now, in #84909 we switched the underlying safe stringify error implementation to the precompiled dependency `safe-stable-stringify`. But it increased the client bundle size a bit. The change in #84909 was only for applying the `safe-stable-stringify` for client file logger with mcp, not really necessary need to change for is-error helper Note: Save minified around 12kb. it's actually 7.5kb on bundlephobia, but because we're using ncc to compile it to cjs dependency that the size seems slightly larger than their metrics. The saved gzip size would be around 2-3.x kb
…#85779) ### What? Introduces a null-rendering default component for interception routes to prevent 404 responses when children slots are missing. ### Why? When rendering interception routes like `(.)[id]`, there's a segment mismatch where the interception route lacks a children slot that the base `[id]` route has. **The Bug:** Previously, the framework injected a 404 page into the missing default slot for the children route. On platforms like Vercel, this caused full 404 RSC responses because the HTTP status code has semantic meaning for route behavior when using cache components. This resulted in the "unknown segment value fallback page" issue. **Impact:** - RSC requests for interception routes would return 404 status codes - Platform routing behavior was incorrectly triggered by these 404 responses - Only affects pages rendering with cache components ### How? - Created new `default-null.tsx` builtin component that renders `null` - Updated Rust code (`app_structure.rs`) to detect interception routes and use the null default - Updated webpack loader (`next-app-loader/index.ts`) to check `isInterceptionRouteAppPath()` and inject the null default - Removed test-specific default component that was working around this bug - The old `page.tsx` is still used during client navigation, so there's no visible change to users This ensures minimal RSC payload changes and prevents 404 status codes while maintaining existing client-side behavior. NAR-483
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )