[pull] canary from vercel:canary #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to #86273 The typed routes test was checking for `/project/[slug]` in the `RedirectRoutes` type, but this route doesn't actually exist in the test fixture anymore. The test fixture only has redirects defined for `/blog/[category]/[[...slug]]`. When Next.js generates the typed routes during the build, it only includes routes that actually exist in the project structure. The test was expecting a route that wasn't present, which would cause the test to fail if the generated types were correct. This removes `/project/[slug]` from the expected `RedirectRoutes` type so the test expectations match what's actually generated. Also includes a minor formatting fix in `apps/bundle-analyzer/next-env.d.ts` to use consistent semicolons and double quotes per the project's style guidelines.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )