[pull] canary from vercel:canary #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it tried to compute the hash of some pages router endpoints, even they weren't in the graph (because there is no `pages` folder)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
Alias "unused import removal" Closes PACK-5782 Performance: ``` * 58fe2e2 - WIP: enable by default pnpm next build --experimental-build-mode=compile > ~/Downloads/log.txt 2>&1 380.01s user 53.74s system 691% cpu 1:02.76 total pnpm next build --experimental-build-mode=compile > ~/Downloads/log.txt 2>&1 384.99s user 51.00s system 708% cpu 1:01.57 total pnpm next build --experimental-build-mode=compile > ~/Downloads/log.txt 2>&1 381.52s user 46.86s system 711% cpu 1:00.21 total vs canary: * f6c2d49 - Turbopack: add task_id_details feature (#84970) pnpm next build --experimental-build-mode=compile > ~/Downloads/log.txt 2>&1 374.87s user 48.47s system 760% cpu 55.662 total pnpm next build --experimental-build-mode=compile > ~/Downloads/log.txt 2>&1 379.18s user 50.27s system 700% cpu 1:01.28 total pnpm next build --experimental-build-mode=compile > ~/Downloads/log.txt 2>&1 370.39s user 45.93s system 726% cpu 57.305 total pnpm next build --experimental-build-mode=compile > ~/Downloads/log.txt 2>&1 372.70s user 46.24s system 717% cpu 58.364 total ```
…pl on `RcStr` (#86522) Stuff like empty `RcStr`s look really confusing if we use `Display`. Also stop using the alternate debug mode for `String`, as it looks like the alternate flag doesn't do anything in this case.
This auto-generated PR updates font data with latest available
…86014) Previously, in a `'use cache'` module, we only compiled statically-known exported functions and arrow expressions to cache functions. Now, we also compile re-exports and exports of values that might be functions. This includes exports like: - `export { getData } from './data'` - re-exporting from another module - `export const aliased = getData` - exporting an imported identifier - `const Page = withSlug(...); export default Page` - exporting the result of a function call These cases can't be statically verified as functions at compile time, so we generate runtime wrappers with `typeof === "function"` checks (simplified): ```js let $$RSC_SERVER_CACHE_getData = getData; if (typeof getData === "function") { $$RSC_SERVER_CACHE_getData = React.cache(function() { return cache("default", "...", 0, getData, arguments); }); registerServerReference($$RSC_SERVER_CACHE_getData, "...", null); Object.defineProperty($$RSC_SERVER_CACHE_getData, "name", { value: "getData" }); } export { $$RSC_SERVER_CACHE_getData as getData }; ``` This ensures that all function exports from `'use cache'` modules are properly cached, while non-function exports pass through unchanged. This approach comes with some limitations compared to statically-known function exports: 1. **No compile-time type checking:** We can't verify that these exports are actually functions. Non-function exports will be passed through as-is at runtime. 2. **No async enforcement:** We can't enforce that functions must be async (as we do for statically-known functions). Synchronous functions are supported, but will lie about their type signature. They become async after being wrapped as cache functions, even though their original signature was synchronous. closes NAR-196
In production, when throwing an error in `'use cache'` at runtime, we are currently logging the obfuscated error that React is producing when crossing the cache-server boundary. This is not ideal for investigating production issues so we're also logging the original error in the `'use cache'` wrapper. But this error does not have a digest, which makes it non-obvious that it's the same error as the obfuscated one. This PR is just adding a test fixture for this case, so that we can see the changes when improving the error handling in the upstack PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )