[pull] canary from vercel:canary #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update rspack binding to 1.6.7 For detailed release information, please see https://github.com/web-infra-dev/rspack/releases. Test case passed in #86853
This auto-generated PR updates the production integration test manifest used when testing Rspack.
…ermines that they are. (#86398) This implements some simple static analysis to determine if modules are side effect free based on their top level module evaluation items. The rules are simple * declarations ✅ * literals ✅ * property access ✅ (potentially controversal but consistent with other bundlers) * function calls ❌ (unless part of an builtin allowlist, e.g. `Object.keys`) imports are obviously the difficult part, for that reason we can evaluate a module to `SideEffectful` `SideEffectFree` or `ModuleEvaluationIsSideEffectFree`. A later step will leverage a graph analysis step to determine of transitive dependencies of ModuleEvaluationIsSideEffectFree modules are also side effect free and upgrade it. So for right now the impact is minor. There is also an experimental option to disable it in case it causes trouble this can help us debug I tested the performance on vercel site and as expected it isn't really observable with side effect analysis disabled ``` ~/projects/front/apps/vercel-site (main *)$ hyperfine -p 'rm -rf .next' -w 2 -r 20 'pnpm next build --turbopack --experimental-build-mode=compile' Benchmark 1: pnpm next build --turbopack --experimental-build-mode=compile Time (mean ± σ): 48.017 s ± 1.696 s [User: 319.651 s, System: 44.273 s] Range (min … max): 44.855 s … 50.600 s 20 runs ``` With it enabled. ``` ~/projects/front/apps/vercel-site (main *)$ hyperfine -p 'rm -rf .next' -w 2 -r 20 'pnpm next build --turbopack --experimental-build-mode=compile' Benchmark 1: pnpm next build --turbopack --experimental-build-mode=compile Time (mean ± σ): 48.038 s ± 2.337 s [User: 320.261 s, System: 45.434 s] Range (min … max): 44.156 s … 52.774 s 20 runs ``` so if there is a regression it is well within the noise.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )