[pull] main from vercel:main #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Extracts the `gitignore` module from `turborepo-lib` into its own `turborepo-gitignore` crate. - Creates new `crates/turborepo-gitignore/` with the `ensure_turbo_is_gitignored()` function - Updates `turborepo-lib` to depend on the new crate - Removes the internal `gitignore` module from `turborepo-lib` This continues the effort to modularize `turborepo-lib` by extracting self-contained functionality into standalone crates. ## Testing - `cargo check -p turborepo-gitignore` ✅ - `cargo check -p turborepo-lib` ✅ - `cargo test -p turborepo-gitignore` ✅ (5 tests pass)
…11318) ## Summary Extract the self-contained `rewrite_json` module into its own crate as part of the ongoing `turborepo-lib` modularization effort. - Create new `turborepo-json-rewrite` crate with `jsonc-parser` dependency - Re-export from `turborepo-lib` to preserve existing internal usages - All 14 existing tests pass ## Details This module provides JSON document mutation utilities (`set_path`, `unset_path`) used for modifying `turbo.json` configuration files. It has **zero internal dependencies**, making it an ideal first extraction candidate. The re-export pattern (`pub use turborepo_json_rewrite as rewrite_json;`) ensures all existing internal usages continue to work without modification. ## Test Plan - `cargo check -p turborepo-json-rewrite -p turborepo-lib` ✅ - `cargo test -p turborepo-json-rewrite` ✅ (14 tests pass)
…rborepo-lib` (#11319) ## Summary Continues the modularization of `turborepo-lib` by extracting the `hash/` module into a standalone `turborepo-hash` crate. Also introduces `turborepo-types` as a foundation crate for shared types. ### New Crates - **`turborepo-types`**: A foundation layer crate containing shared types (`EnvMode`, `TaskOutputs`) that are used across multiple crates. This prevents circular dependencies during future extractions. - **`turborepo-hash`**: Contains all hashing functionality using Cap'n Proto for deterministic serialization across languages/platforms, plus xxHash64 for fast hashing. ### Verification - All 559 tests pass (545 `turborepo-lib` + 11 `turborepo-hash` + 3 `turborepo-types`) - Hash values are identical (verified via hardcoded test assertions) - `proto.capnp` and `traits.rs` are byte-for-byte identical - Type definitions preserve all derives and serde attributes
## Summary - Extract the `shim/` module from `turborepo-lib` into a standalone `turborepo-shim` crate - Use trait-based dependency injection to decouple shim logic from turborepo-lib internals - Maintain full backward compatibility via re-exports in `turborepo-lib/src/shim.rs` ## Details This PR continues the modularization effort by extracting the shim module, which handles: - CLI argument parsing (`ShimArgs`) - Local turbo binary detection (`LocalTurboState`) - Turbo version detection from lockfiles (`LocalTurboConfig`) - Platform-specific turbo state helpers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )