Skip to content

refactor(table): remove kv interface virtual dispatch#182

Open
zz-jason wants to merge 1 commit intomainfrom
jian.z/kv-interface
Open

refactor(table): remove kv interface virtual dispatch#182
zz-jason wants to merge 1 commit intomainfrom
jian.z/kv-interface

Conversation

@zz-jason
Copy link
Owner

@zz-jason zz-jason commented Feb 1, 2026

Co-Authored-By: Codex codex@openai.com

Co-Authored-By: Codex <codex@openai.com>
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 42.50000% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.44%. Comparing base (30e7b51) to head (3b45f82).

Files with missing lines Patch % Lines
src/table/table.cpp 43.47% 34 Missing and 5 partials ⚠️
src/lean_store.cpp 0.00% 6 Missing ⚠️
src/table/table_column_store.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   52.36%   52.44%   +0.07%     
==========================================
  Files         157      157              
  Lines       11027    11056      +29     
  Branches     4752     4767      +15     
==========================================
+ Hits         5774     5798      +24     
- Misses       4524     4534      +10     
+ Partials      729      724       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

[CORO] Bench YCSB B on BasicKV

�[1;32m[INFO]�[0m YCSB runner thread started: 0
�[1;32m[INFO]�[0m YCSB runner thread started: 1
�[1;32m[INFO]�[0m YCSB runner thread started: 2
�[1;32m[INFO]�[0m YCSB runner thread started: 3
�[1;32m[INFO]�[0m YCSB runner thread started: 4
�[1;32m[INFO]�[0m YCSB runner thread started: 5
�[1;32m[INFO]�[0m [1s] [TPS=282897] [COMMITTED=282897] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [2s] [TPS=302094] [COMMITTED=302094] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [3s] [TPS=321165] [COMMITTED=321165] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [4s] [TPS=309300] [COMMITTED=309300] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [5s] [TPS=304274] [COMMITTED=304274] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [6s] [TPS=306565] [COMMITTED=306565] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [7s] [TPS=310123] [COMMITTED=310123] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [8s] [TPS=308966] [COMMITTED=308966] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [9s] [TPS=291756] [COMMITTED=291756] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [10s] [TPS=309692] [COMMITTED=309692] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [11s] [TPS=326027] [COMMITTED=326027] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [12s] [TPS=316492] [COMMITTED=316492] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [13s] [TPS=321397] [COMMITTED=321397] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [14s] [TPS=327244] [COMMITTED=327244] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [15s] [TPS=323714] [COMMITTED=323714] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [16s] [TPS=324775] [COMMITTED=324775] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [17s] [TPS=330843] [COMMITTED=330843] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [18s] [TPS=332496] [COMMITTED=332496] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [19s] [TPS=329098] [COMMITTED=329098] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [20s] [TPS=320561] [COMMITTED=320561] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [21s] [TPS=331962] [COMMITTED=331962] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [22s] [TPS=325113] [COMMITTED=325113] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [23s] [TPS=324684] [COMMITTED=324684] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [24s] [TPS=327899] [COMMITTED=327899] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [25s] [TPS=332688] [COMMITTED=332688] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [26s] [TPS=322323] [COMMITTED=322323] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [27s] [TPS=315634] [COMMITTED=315634] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [28s] [TPS=325666] [COMMITTED=325666] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [29s] [TPS=325926] [COMMITTED=325926] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m �[1;32m[INFO]�[0m YCSB runner thread finished: 2
�[1;32m[INFO]�[0m YCSB runner thread finished: 3
YCSB runner thread finished: 4
�[1;32m[INFO]�[0m �[1;32m[INFO]�[0m YCSB runner thread finished: 5
�[1;32m[INFO]�[0m YCSB runner thread finished: 0
YCSB runner thread finished: 1
�[1;32m[INFO]�[0m [30s] [TPS=321954] [COMMITTED=321954] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m Summary:
  -clients: 6
  -total_time_sec: 30
  -avg_tps: 318444
  -total_committed: 9553328
  -total_aborted: 0
  -total_abort_rate: 0.00%

[CORO] Bench YCSB B on TransactionKV

�[1;32m[INFO]�[0m YCSB runner thread started: 0
�[1;32m[INFO]�[0m YCSB runner thread started: 1
�[1;32m[INFO]�[0m YCSB runner thread started: 2
�[1;32m[INFO]�[0m YCSB runner thread started: 3
�[1;32m[INFO]�[0m YCSB runner thread started: 4
�[1;32m[INFO]�[0m YCSB runner thread started: 5
�[1;32m[INFO]�[0m [1s] [TPS=177592] [COMMITTED=177592] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [2s] [TPS=186050] [COMMITTED=186049] [ABORTED=1] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [3s] [TPS=190970] [COMMITTED=190970] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [4s] [TPS=190230] [COMMITTED=190229] [ABORTED=1] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [5s] [TPS=186930] [COMMITTED=186930] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [6s] [TPS=188784] [COMMITTED=188783] [ABORTED=1] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [7s] [TPS=187867] [COMMITTED=187865] [ABORTED=2] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [8s] [TPS=191495] [COMMITTED=191492] [ABORTED=3] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [9s] [TPS=189136] [COMMITTED=189133] [ABORTED=3] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [10s] [TPS=191106] [COMMITTED=191105] [ABORTED=1] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [11s] [TPS=192038] [COMMITTED=192035] [ABORTED=3] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [12s] [TPS=192710] [COMMITTED=192709] [ABORTED=1] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [13s] [TPS=193135] [COMMITTED=193133] [ABORTED=2] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [14s] [TPS=192947] [COMMITTED=192942] [ABORTED=5] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [15s] [TPS=191311] [COMMITTED=191306] [ABORTED=5] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [16s] [TPS=190298] [COMMITTED=190296] [ABORTED=2] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [17s] [TPS=188865] [COMMITTED=188860] [ABORTED=5] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [18s] [TPS=188953] [COMMITTED=188953] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [19s] [TPS=190456] [COMMITTED=190451] [ABORTED=5] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [20s] [TPS=189721] [COMMITTED=189719] [ABORTED=2] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [21s] [TPS=190397] [COMMITTED=190396] [ABORTED=1] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [22s] [TPS=189715] [COMMITTED=189712] [ABORTED=3] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [23s] [TPS=188174] [COMMITTED=188171] [ABORTED=3] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [24s] [TPS=186928] [COMMITTED=186925] [ABORTED=3] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [25s] [TPS=189669] [COMMITTED=189664] [ABORTED=5] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [26s] [TPS=189650] [COMMITTED=189647] [ABORTED=3] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [27s] [TPS=192395] [COMMITTED=192395] [ABORTED=0] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [28s] [TPS=191857] [COMMITTED=191853] [ABORTED=4] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m [29s] [TPS=189578] [COMMITTED=189576] [ABORTED=2] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m YCSB runner thread finished: 4
�[1;32m[INFO]�[0m �[1;32m[INFO]�[0m YCSB runner thread finished: 2YCSB runner thread finished: 1

�[1;32m[INFO]�[0m YCSB runner thread finished: 5
�[1;32m[INFO]�[0m YCSB runner thread finished: 0
�[1;32m[INFO]�[0m YCSB runner thread finished: 3
�[1;32m[INFO]�[0m [30s] [TPS=188772] [COMMITTED=188769] [ABORTED=3] [ABORT_RATE=0.00%]
�[1;32m[INFO]�[0m Summary:
  -clients: 6
  -total_time_sec: 30
  -avg_tps: 189590
  -total_committed: 5687660
  -total_aborted: 69
  -total_abort_rate: 0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments