Fix standards eyebrow copy and dev server log spacing#400
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
et3 | 9cb255f | Commit Preview URL Branch Preview URL |
Jan 14 2026, 03:43 PM |
Summary of ChangesHello @zz-plant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses minor copy and formatting inconsistencies to ensure that the user interface text and documentation examples are precisely aligned with the actual site content and development server logs. The changes are purely editorial, focusing on improving clarity and accuracy in both the UI and developer documentation, without impacting any runtime behavior or functionality of the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces two small but valuable fixes to copy and formatting. The change to use 'Active standards' is appropriate given there are multiple standards, and the fix to the log example in the documentation improves clarity. The changes are correct. I have added one suggestion on the standards page to improve maintainability by centralizing content strings, which could make future updates easier.
| <SectionBlock | ||
| id="active" | ||
| eyebrow="Active standard" | ||
| eyebrow="Active standards" |
There was a problem hiding this comment.
While this change correctly pluralizes the text, this eyebrow string, along with the title and description on the following lines, are hardcoded. For better maintainability, it's a good practice to centralize content like this in a single source, such as your src/content/standards.ts file. This would make future content updates easier and keep your component templates cleaner.
For example, you could add a new property to your standardsContent object:
// in src/content/standards.ts
export const standardsContent: StandardsContent = {
// ... other properties
activeSection: {
eyebrow: "Active standards",
title: "Now active",
description: "Drafts and ratified standards in the publication queue."
}
};And then use it in this component:
// in src/pages/standards/index.astro
<SectionBlock
id="active"
eyebrow={standardsContent.activeSection.eyebrow}
title={standardsContent.activeSection.title}
description={standardsContent.activeSection.description}
>This is a suggestion for a broader improvement and could be applied to other sections in this file as well.
Motivation
Description
src/pages/standards/index.astrofrom"Active standard"to"Active standards"to reflect multiple entries.docs/local-development.mdso the example readsLocal http://localhost:4321/without the extra gap.Testing
bun run check(which runs linting, unit tests, typechecking, Astro checks, and JSON/glossary validation) and it completed successfully.bun testexecuted the unit/component suite (17 tests: 14 pass, 3 skip) andastro checkran with hints but no errors.Codex Task