Reorder landing page sections for clearer user flow#404
Conversation
Summary of ChangesHello @zz-plant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience on the landing and 'Start Here' pages by strategically reordering content sections. The changes aim to guide visitors more effectively by presenting crucial information like audience selection, framing, and quick-start options earlier in the flow, thereby reducing cognitive load and enabling quicker navigation to relevant content. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively reorders sections on the landing and 'start-here' pages to create a more logical user flow. The changes are consistently applied across the Astro components and the corresponding JSON content file. The code is clean and the changes align well with the stated motivation. I have one suggestion to improve accessibility by removing a redundant aria-label attribute.
| <a | ||
| class="button primary button--compact" | ||
| href={preview.href} | ||
| aria-label={preview.label} |
There was a problem hiding this comment.
The aria-label attribute here is redundant because its value is the same as the link's text content. When link text is already descriptive, an aria-label is not necessary. Screen readers will prioritize the aria-label, so while this doesn't cause a functional issue, removing it simplifies the code and adheres to accessibility best practices.
Motivation
framingandquick-startguidance before artifact previews on the Start Here page.Description
SectionBlockwithid="audience"earlier insrc/pages/index.astroso the audience selector appears before outputs and workflow sections.src/pages/start-here/index.astroto render theframingblock beforeroutesand to move theartifactspreviews after thequick-startsection.src/content/start-here.jsonto reorder theanchorLinksto match the new section order.Testing
bun run typecheckand it passed.bun run astro:checkand it passed.bun run check(includes lint, unit tests, typecheck, Astro check, and content validations) and all checks passed.Codex Task