Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the dns_resolver method in the HTTP client builder to improve its ergonomics by accepting any type that can be converted into Arc<dyn Resolve + 'static> rather than requiring the caller to pre-wrap the resolver in an Arc.
- Simplified the method signature to accept generic types implementing
Into<Arc<dyn Resolve + 'static>> - Replaced explicit type casting with
.into()for cleaner conversion
dns_resolver method ergonomicsdns_resolver
dns_resolver?Sized trait objects in dns_resolver
0x676e67
marked this pull request as ready for review
August 6, 2025 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
?Sizedtype