Skip to content

refactor(client): allow ?Sized trait objects in dns_resolver #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0x676e67 merged 2 commits into from
Aug 6, 2025
+2 −2
Merged

refactor(client): allow ?Sized trait objects in dns_resolver #870

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28a79b
refactor(client): improve `dns_resolver` method ergonomics
0x676e67 Aug 5, 2025
0ec0a77
update
0x676e67 Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/client/http/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,8 +1246,8 @@ impl ClientBuilder {
/// Overrides for specific names passed to `resolve` and `resolve_to_addrs` will
/// still be applied on top of this resolver.
#[inline]
pub fn dns_resolver<R: Resolve + 'static>(mut self, resolver: Arc<R>) -> ClientBuilder {
self.config.dns_resolver = Some(resolver as _);
pub fn dns_resolver(mut self, resolver: Arc<dyn Resolve>) -> ClientBuilder {
self.config.dns_resolver = Some(resolver);
self
}

Expand Down
Loading