Add verifier-datas tree (set) & in-circuit verification#274
Merged
Conversation
…tyPod,frontend,etc.
…mt_containers instead of the global constant MAX_DEPTH
arnaucube
changed the title
arnaucube
force-pushed
the
verifierdatas-set
branch
3 times, most recently
from
d7bf346 to
b6dd348
Compare
arnaucube
force-pushed
the
verifierdatas-set
branch
from
b6dd348 to
f4bd18a
Compare
ed255
requested changes
Jun 10, 2025
arnaucube
force-pushed
the
verifierdatas-set
branch
from
f3e588e to
3bbb4b8
Compare
…two existing set_targets methods of MainPodVerifyTarget
arnaucube
force-pushed
the
verifierdatas-set
branch
from
a872c65 to
e2c4a65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating a MainPod, the circuit checks that the used verifier_datas for the verification of the recursive proofs, appear in the set of allowed verifier_datas (which is a
containers::Set, a merkletree).VDSetconstructionVDSetproofs verification in the MainPod's circuitDictionary,Set,Array)MAX_DEPTHin most of places except for 3 locations, opened the issue remove the global constantMAX_DEPTHand use the respective value fromParamsinstead #273 describing it.This PR should resolve #249 , resolve #250.