Modernize tada crate dependencies so it compiles and tests pass - #11
Open
evolvedmicrobe wants to merge 1 commit into
Open
Modernize tada crate dependencies so it compiles and tests pass#11evolvedmicrobe wants to merge 1 commit into
evolvedmicrobe wants to merge 1 commit into
Conversation
The tada crate hadn't been touched since 2017 and used wildcard "*" dependency versions throughout, so a fresh checkout resolved today's incompatible latest releases and failed to build (it also referenced a build.rs that never existed in git history). Pinned every dependency to a current major version, dropped the unused `bio` dependency, and migrated call sites off removed/changed APIs: rustc-serialize -> serde + serde_json, old bincode/docopt/log/fern/rand/crossbeam/csv/flate2 APIs -> their current equivalents. `cargo build` and `cargo test` both pass; RNG output is no longer bit-identical to the old binary (XorShiftRng -> SmallRng) but is still deterministic per seed. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/tadahadn't been built since ~2017 and used wildcard"*"dependency versions, so a fresh checkout resolved today's incompatible latest crate releases and failed to compile (it also referenced abuild.rsthat never existed in git history).lib/tadaand its three vendoredexternal/*crates (martian,rust-shardio,rust-fastq-10x) to current major versions, and dropped thebiodependency entirely (it was declared but only referenced from commented-out code).rustc-serialize→serde/serde_json, oldbincode/docopt/log/fern/rand/crossbeam/csv/flate2APIs → their current equivalents.build.rs(git-describe based version stamp, used bytada --version).Notes
XorShiftRng→rand::rngs::SmallRng), but is still deterministic per seed.Results, elided lifetimes, missing-ABIextern fns) — left alone since they don't block the build.Test plan
cargo buildsucceeds (exit 0)cargo build --releasesucceedscargo testpasses: 27/27 tests across both the lib and bin test targets, plus doc-teststada --versionruns and prints the expected git/rustc version info🤖 Generated with Claude Code