Single passkey only on eBay and PayPal #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arxo <[email protected]>
Signed-off-by: arxo <[email protected]>
checks complained about regions: Error: -cu is not a valid region code Error: -kp is not a valid region code Error: -ir is not a valid region code Error: -sy is not a valid region code Error: -ve is not a valid region code Error: -ru is not a valid region code Error: -tr is not a valid region code Signed-off-by: arxo <[email protected]>
|
someone should have a look at the PR validator failure... |
|
As the requested changes haven't been resolved yet, this PR will be marked as inactive.
|
github-actions
bot
added
the
inactive
hkamran80
added
multiple sites
|
Any idea what todo about this issue? |
hkamran80
reviewed
Mar 17, 2025
entries/e/ebay.com.json
Outdated
Comment on lines
31
to
39
| "regions": [ | ||
| "-cu", | ||
| "-kp", | ||
| "-ir", | ||
| "-sy", | ||
| "-ve", | ||
| "-ru", | ||
| "-tr" | ||
| ] |
There was a problem hiding this comment.
Why did you remove the regions array?
There was a problem hiding this comment.
Because the JavaScript tests complained about every single one of the regions until I removed all of them.
There was a problem hiding this comment.
I'll revert that particular change to see if it somehow works now.
There was a problem hiding this comment.
JS test now fails again.
hopefully the failing JS tests were just temporary Signed-off-by: arxo <[email protected]>
Carlgo11
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #16 and #17