Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single passkey only on eBay and PayPal #43

Merged
merged 4 commits into from
Mar 19, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions entries/e/ebay.com.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.com/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.com.au/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.at/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.be/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.ca/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.cn/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.fr/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.de/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.com.hk/

Check warning on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / JavaScript tests

Unable to fetch https://ebay.in/

Check failure on line 1 in entries/e/ebay.com.json

View workflow job for this annotation

GitHub Actions / External Tests

Similarweb rank 345,251 exceeds the limit of 200,000.
"eBay": {
"additional-domains": [
"ebay.com.au",
Expand Down Expand Up @@ -26,16 +26,8 @@
],
"img": "ebay.svg",
"passwordless": "allowed",
"notes": "Cannot register multiple passkeys.",
"documentation": "https://www.ebay.com/help/account/signing-account/signing-account?id=4189#section2",
"categories": "retail",
"regions": [
"-cu",
"-kp",
"-ir",
"-sy",
"-ve",
"-ru",
"-tr"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the regions array?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the JavaScript tests complained about every single one of the regions until I removed all of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert that particular change to see if it somehow works now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS test now fails again.

"categories": "retail"
}
}
2 changes: 1 addition & 1 deletion entries/p/paypal.com.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"paypal-search.com"
],
"passwordless": "allowed",
"notes": "An eligible Apple or Android device is required to create a passkey.",
"notes": "Cannot register multiple passkeys. An eligible Apple or Android device is required to create a passkey.",
"documentation": "https://www.paypal.com/us/cshelp/article/help997",
"categories": "payments"
}
Expand Down
Loading