Don't manage the k8s secret for prometheus auth from this chart - #121
Merged
Conversation
Member
|
YES please |
jnywong
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref 2i2c-org/infrastructure#8851
Currently this chart gets the
prometheususernameandpasswordviavalues.yaml, then puts it in a k8s secret and has the deployment consume it.What happens in practice, in our 2i2c deployments of this chart, is that we end up with two k8s secrets that manage the prometheus creds. One managed by this deployment and one managed by
basehub, each needing its ownvalues.yamlsetup, which results having two places where we need to maintain this info.This PR has
prometheusAuth.envFromSecretspecify the name of the secret where the promethususernameandpasswordis and uses that instead. This is similar to how we setup grafana credshttps://github.com/2i2c-org/infrastructure/blob/81b82d1a1646de73074c46e23e864612ebf8497f/helm-charts/support/values.yaml#L359