Skip to content

Don't manage the k8s secret for prometheus auth from this chart #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnywong merged 1 commit into from
Jul 31, 2026
Merged

Don't manage the k8s secret for prometheus auth from this chart #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions helm/jupyterhub-cost-monitoring/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,18 @@ spec:
{{- with .Values.extraEnv }}
{{- tpl (. | toYaml) $ | nindent 12 }}
{{- end }}
{{- if .Values.prometheusAuth.enabled }}
- name: PROMETHEUS_USERNAME
valueFrom:
secretKeyRef:
name: {{ include "jupyterhub-cost-monitoring.webserver.fullname" . }}
name: {{ .Values.prometheusAuth.envFromSecret }}
key: username
- name: PROMETHEUS_PASSWORD
valueFrom:
secretKeyRef:
name: {{ include "jupyterhub-cost-monitoring.webserver.fullname" . }}
name: {{ .Values.prometheusAuth.envFromSecret }}
key: password
{{- end }}
resources:
{{- .Values.resources | toYaml | nindent 12 }}
securityContext:
Expand Down
9 changes: 0 additions & 9 deletions helm/jupyterhub-cost-monitoring/templates/secret.yaml
View file
Open in desktop

This file was deleted.

16 changes: 12 additions & 4 deletions helm/jupyterhub-cost-monitoring/values.schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,16 @@ prometheusAuth:
properties:
enabled:
type: boolean
username:
envFromSecret:
type: string
password:
type: string
required: [enabled]
required: [enabled]
# If enabled, then make envFromSecret mandatory
anyOf:
- properties:
enabled:
const: true
required:
- envFromSecret
- properties:
enabled:
const: false
3 changes: 1 addition & 2 deletions helm/jupyterhub-cost-monitoring/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,4 @@ networkPolicy:
#
prometheusAuth:
enabled: false
username: ""
password: ""
envFromSecret: ""
Loading