Skip to content

Conversation

@Y1hsiaochunnn
Copy link
Contributor

At present, the backlight of esp32-p4-nano has not been adapted, and the backlight control conflicts with the es8311 i2c when working at the same time

tested

@Y1hsiaochunnn
Copy link
Contributor Author

Please review this PR first. The two PRS are related

78/esp-wifi-connect#11

@78
Copy link
Owner

78 commented Apr 17, 2025

Thanks for pushing the first P4 board.
Can the directory name include "waveshare"? For example, I think "esp-box-3" is quite distinctive. Then, it's better to add a README.md file under this directory and include the product website URL of this development board.

@Y1hsiaochunnn
Copy link
Contributor Author

Adding the prefix "Waveshare" to all waveshare products has been compiled through esp-idf. It is not known whether it will affect the unified packaging, so it needs to be reviewed again.

btw, just a hint, reduce the workload, ESP-wifi-connect PR only merge should not be possible, we have to push the new version to the ESP Component Registry, usually I push it automatically through Actions, you can refer to this article:https://github.com/waveshareteam/Waveshare-ESP32-components/blob/master/.github/workflows/upload_component.yml

@78
Copy link
Owner

78 commented Apr 18, 2025

It will indeed have an impact on the previously released firmwares. As they require the same build names for over-the-air (OTA) upgrades. It is advisable not to alter the build names of the other boards. Nevertheless, starting from the esp32-p4-nano board, the vendor name can be added.

@Y1hsiaochunnn
Copy link
Contributor Author

ok, I'll fix it

@78
Copy link
Owner

78 commented Apr 18, 2025

ok, I'll fix it

Or just keep it. I can fix this on the OTA server.

@78
Copy link
Owner

78 commented May 6, 2025

Kindly assist in using naming rules such as esp-spot-s3 for the board name and resolving file conflicts.

@Y1hsiaochunnn
Copy link
Contributor Author

Kindly assist in using naming rules such as esp-spot-s3 for the board name and resolving file conflicts.

so,I need to change the board name back?

@78
Copy link
Owner

78 commented May 8, 2025

Kindly assist in using naming rules such as esp-spot-s3 for the board name and resolving file conflicts.

so,I need to change the board name back?

Yes. Don't change other boards' names. Keep them unchanged. The name of the P4 board starts with waveshare-p4-nano.

Help fix the code style. For example,

  1. class test_abc to class TestAbc.
  2. Use C++ style instead of C99.
if (true)
{
}

to

if (true) {
}

@Y1hsiaochunnn
Copy link
Contributor Author

Any suggestions, remind me

@Y1hsiaochunnn
Copy link
Contributor Author

Resolved the file conflict and resubmitted the pr
#589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants