-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Adjust ESP32-P4 chip compatibility Add Waveshare ESP32-P4-NANO board support #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please review this PR first. The two PRS are related |
|
Thanks for pushing the first P4 board. |
|
Adding the prefix "Waveshare" to all waveshare products has been compiled through esp-idf. It is not known whether it will affect the unified packaging, so it needs to be reviewed again. btw, just a hint, reduce the workload, ESP-wifi-connect PR only merge should not be possible, we have to push the new version to the ESP Component Registry, usually I push it automatically through Actions, you can refer to this article:https://github.com/waveshareteam/Waveshare-ESP32-components/blob/master/.github/workflows/upload_component.yml |
|
It will indeed have an impact on the previously released firmwares. As they require the same build names for over-the-air (OTA) upgrades. It is advisable not to alter the build names of the other boards. Nevertheless, starting from the esp32-p4-nano board, the vendor name can be added. |
|
ok, I'll fix it |
Or just keep it. I can fix this on the OTA server. |
|
Kindly assist in using naming rules such as |
so,I need to change the board name back? |
Yes. Don't change other boards' names. Keep them unchanged. The name of the P4 board starts with Help fix the code style. For example,
to |
|
Any suggestions, remind me |
|
Resolved the file conflict and resubmitted the pr |
At present, the backlight of esp32-p4-nano has not been adapted, and the backlight control conflicts with the es8311 i2c when working at the same time
tested