Skip to content

Conversation

@Y1hsiaochunnn
Copy link
Contributor

@Y1hsiaochunnn Y1hsiaochunnn commented May 9, 2025

It comes from this pr #509

@78
Copy link
Owner

78 commented May 9, 2025

Adjust the code with: #509 (comment)

@Y1hsiaochunnn
Copy link
Contributor Author

Is there any code need to tweak? Can you point out?

@78
Copy link
Owner

78 commented May 9, 2025

And this?

Don't change other boards' names.
Keep them unchanged. The name of the P4 board starts with waveshare-p4-nano.

@Y1hsiaochunnn
Copy link
Contributor Author

And this?

Don't change other boards' names.
Keep them unchanged. The name of the P4 board starts with waveshare-p4-nano.

so,I would like to return the other waveshare modifications, such as waveshare-esp32-s3-touch-amoled-1.8

Should keep the original name esp32-s3-touch-amoled-1.8,

Can esp32-p4-nano be maintained using waveshare-esp32-p4-nano?

Can I understand it that way?

@78
Copy link
Owner

78 commented May 10, 2025

  1. Should keep the original name esp32-s3-touch-amoled-1.8
    Yes.

  2. Can esp32-p4-nano be maintained using waveshare-esp32-p4-nano?
    esp32 is not necessary. waveshare-p4-nano is OK.

@78
Copy link
Owner

78 commented May 14, 2025

@Y1hsiaochunnn Waiting for your update...

@Y1hsiaochunnn
Copy link
Contributor Author

Y1hsiaochunnn commented May 15, 2025

Hi @78 ,
I have adjusted the code structure according to your requirements, the first ESP32-P4 device adaptation, can you explain in the README.md in the general directory has supported ESP32-P4? Then link to waveshare-ESP32-P4-NANO? At present, the supply of this product is stable

@78
Copy link
Owner

78 commented May 15, 2025

Alright. I can hardly find any problems except Backlight is not implemented.
It's OK to promote it in the root README.
Moreover, I am eager to obtain the opportunity to get one for conducting more tests.

@78 78 merged commit 1c63934 into 78:main May 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants